Add support for cloning pseudo interfaces
ClosedPublic
Actions

Authored by mmacy on May 8 2018, 4:00 AM.

Details

Reviewers

Commits

Summary

Part 3 of many ...
The VPC framework relies heavily on cloning pseudo interfaces (vmnics, vpc switch, vcpswitch port, hostif, vxlan if, etc).

This pulls in that bit. Largely self explanatory. Some ancillary changes get pulled in as a side effect.

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

sys/net/iflib.c
4547 ↗	(On Diff #42258)	This appears to leak ctx and sc.
sys/net/iflib.h
360 ↗	(On Diff #42258)	I don't think this value should be renumbered. It's in stable/11 now as 0x100.

sys/net/iflib.h
360 ↗	(On Diff #42258)	Maybe I'm naive, but this value seems to be only consumed by kernel space. That being said, if someone is trying to use an out of tree KMOD, then there would be a problem right?

sys/net/iflib.h
360 ↗	(On Diff #42258)	Yeah, the main concern is that if someone doesn't rebuild a module across this change, it will behave unexpectedly. Since there's no technical reason to renumber it, it may as well be retained.