Page MenuHomeFreeBSD

Add netdump hooks for mlxen(4).
ClosedPublic

Authored by hselasky on May 1 2018, 5:23 PM.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

sys/dev/mlx4/mlx4_en/mlx4_en_netdev.c
2933 ↗(On Diff #42046)

Polling only TX CQ zero is not correct. See patch I sent to you.

hselasky updated this revision to Diff 46182.
hselasky edited reviewers, added: markj; removed: hselasky.

Update patch with changes from Mellanox.

Please test the updated patch. Thank you. Processing for commit soon.

Don't disable interrupts. They are likely already disabled.

Please test the updated patch. Thank you. Processing for commit soon.

Thanks for the updates, but I no longer have access to access to hardware for testing. It is relatively easy: install the ftp/netdumpd package on a machine with low latency to the test host. Have it write dumps to /tmp:

# cd /tmp
# netdumpd -D -d . -P ./netdumpd.pid

On the test host, give the mlxen interface under test an IP address; configure netdump by specifying the local and server IP address, and the next-hop router if needed:

# dumpon -c <local IP> -s <server IP> -g <gateway IP> mlxen<N>
# sysctl debug.kdb.panic=1

The -g parameter can be omitted if the two hosts are on the same link. Its value can be "default," which causes it to use the current default router.

Hi Hans,

Would you be willing to go ahead and commit this? Thanks.

Hi,

We have this patched queued internally for testing and review. You'd like to have it in before 12 is out?

--HPS

We have this patched queued internally for testing and review. You'd like to have it in before 12 is out?

I am not worried too much about whether it makes 12 or not, just want to make sure it doesn't get lost. I didn't see any phabricator activity since August 2, which is why I asked. If it's in the queue and will land eventually, I am happy with that. Thanks!

This revision was not accepted when it landed; it landed in state Needs Review.Dec 5 2018, 1:33 PM
This revision was automatically updated to reflect the committed changes.

Was this tested with an MTU of 9000?