Differential D14645

Fix errneous checks for OF_finddevice(9) return value
ClosedPublic
Actions

Authored by gonzo on Mar 10 2018, 11:47 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Oct 15, 12:08 AM

	Unknown Object (File)
	Mon, Oct 13, 10:44 AM

	Unknown Object (File)
	Mon, Oct 13, 10:36 AM

	Unknown Object (File)
	Mon, Oct 13, 10:35 AM

	Unknown Object (File)
	Tue, Oct 7, 5:12 AM

	Unknown Object (File)
	Sun, Sep 21, 12:04 AM

	Unknown Object (File)
	Sep 5 2025, 3:51 AM

	Unknown Object (File)
	Aug 29 2025, 2:36 AM

View All 78 Files

Subscribers

Details

Reviewers

nwhitehorn
imp
ganbold
br
• ian
zbb
andrew

Commits

rS331229: [ofw] fix errneous checks for OF_finddevice(9) return value

Summary

OF_finddevices returns -1 in case of failure. Some code in
existing drivers checked return value to be equal to 0 or
less/equal to 0. Most of these checks were for negative
cases that were never triggered so trhere was no negative
impact on functionality.

This patch fixes all instances of such erroneous checks.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

gonzo created this revision.Mar 10 2018, 11:47 PM

Herald added a subscriber: jhibbits. · View Herald TranscriptMar 10 2018, 11:47 PM

Harbormaster completed remote builds in B15480: Diff 40145.Mar 10 2018, 11:47 PM

Looks good. Thanks for doing this!

This revision is now accepted and ready to land.Mar 11 2018, 12:04 AM

Closed by commit rS331229: [ofw] fix errneous checks for OF_finddevice(9) return value (authored by gonzo). · Explain WhyMar 20 2018, 12:04 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

arm/

amlogic/

aml8726/

aml8726_clkmsr.c

4 lines

4 lines

aml8726_usb_phy-m3.c

2 lines

annapurna/

alpine/

alpine_machdep.c

2 lines

broadcom/

bcm2835/

4 lines

2 lines

bcm2835_machdep.c

2 lines

freescale/

2 lines

vybrid/

2 lines

mv/

4 lines

samsung/

exynos/

2 lines

2 lines

ti/

am335x/

2 lines

am335x_lcd_syscons.c

2 lines

dev/

fdt/

4 lines

ofw/

2 lines

2 lines

ow/

2 lines

vnic/

thunder_bgx_fdt.c

2 lines

powerpc/

cpufreq/

2 lines

pseries/

platform_chrp.c

2 lines

Diff 40483

head/sys/arm/amlogic/aml8726/aml8726_clkmsr.c

Loading...

head/sys/arm/amlogic/aml8726/aml8726_mp.c

Loading...

head/sys/arm/amlogic/aml8726/aml8726_usb_phy-m3.c

Loading...

head/sys/arm/annapurna/alpine/alpine_machdep.c

Loading...

head/sys/arm/broadcom/bcm2835/bcm2835_fb.c

Loading...

head/sys/arm/broadcom/bcm2835/bcm2835_fbd.c

Loading...

head/sys/arm/broadcom/bcm2835/bcm2835_machdep.c

Loading...

head/sys/arm/freescale/fsl_ocotp.c

Loading...

head/sys/arm/freescale/vybrid/vf_machdep.c

Loading...

head/sys/arm/mv/mv_common.c

Loading...

head/sys/arm/samsung/exynos/chrome_ec.c

Loading...

head/sys/arm/samsung/exynos/exynos5_ehci.c

Loading...

head/sys/arm/ti/am335x/am335x_lcd.c

Loading...

head/sys/arm/ti/am335x/am335x_lcd_syscons.c

Loading...

head/sys/dev/fdt/fdt_common.c

Loading...

head/sys/dev/ofw/ofw_subr.c

Loading...

head/sys/dev/ofw/openfirmio.c

Loading...

head/sys/dev/ow/owc_gpiobus.c

Loading...

head/sys/dev/vnic/thunder_bgx_fdt.c

Loading...

head/sys/powerpc/cpufreq/mpc85xx_jog.c

Loading...

head/sys/powerpc/pseries/platform_chrp.c

Loading...