Page MenuHomeFreeBSD

Remove very old and unused signal information codes.
ClosedPublic

Authored by jhb on Mar 10 2018, 12:03 AM.
Tags
None
Referenced Files
F132993057: D14637.id.diff
Tue, Oct 21, 9:44 PM
F132989154: D14637.id40252.diff
Tue, Oct 21, 8:59 PM
Unknown Object (File)
Tue, Oct 21, 8:20 PM
Unknown Object (File)
Tue, Oct 21, 8:20 PM
Unknown Object (File)
Tue, Oct 21, 8:55 AM
Unknown Object (File)
Fri, Oct 17, 11:00 PM
Unknown Object (File)
Thu, Oct 9, 3:22 AM
Unknown Object (File)
Sep 20 2025, 12:29 PM
Subscribers

Details

Summary

These have been supplanted by the MI signal information codes in
<sys/signal.h> since 7.0. The FPE_*_TRAP ones were deprecated even
earlier in 1999.

Test Plan
  • waiting on a tinderbox to finish, but I'm quite certain these aren't used anywhere

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 15544
Build 15582: arc lint + arc unit

Event Timeline

sys/x86/include/signal.h
48

I do not object against this part, but the pollution might be relied upon by third-party software. I do not know.

sys/x86/include/trap.h
88

At least BUS_PAGE_FAULT is used in kernel.

sys/x86/include/signal.h
48

I can request an exp-run to check for this.

sys/x86/include/trap.h
88

This is only for legacy binaries though (< 7.0), so I think we can just hide that specific use case under #ifdef _KERNEL. We could also make the tunable depend on #ifdef COMPAT_FREEBSD6? (And just always use SIGSEGV on kernels without COMPAT_FREEBSD6?) Alternatively, the compat shim could just use 'T_PAGEFLT' directly for ucode (this matches what the code did prior to the siginfo commit).

sys/x86/include/signal.h
48

Ok.

sys/x86/include/trap.h
88

I do not see a reason to not use T_PAGEFLT directly.

  • Use T_PAGEFLT directly for the legacy page fault signal code.
  • Use T_PAGEFLT on i386 as well.
  • Add <machine/trap.h> #include's.
This revision is now accepted and ready to land.Mar 13 2018, 5:49 PM
This revision was automatically updated to reflect the committed changes.