Differential D14637

Remove very old and unused signal information codes.
ClosedPublic
Actions

Authored by jhb on Mar 10 2018, 12:03 AM.

Tags

None

Referenced Files

	F170985009: D14637.id40120.diff
	Tue, Sep 8, 12:40 AM

	F170966581: D14637.id40821.diff
	Mon, Sep 7, 10:04 PM

	F170928028: D14637.id40252.diff
	Mon, Sep 7, 4:13 PM

	Unknown Object (File)
	Mon, Sep 7, 12:38 AM

	Unknown Object (File)
	Sun, Sep 6, 6:06 PM

	Unknown Object (File)
	Sun, Sep 6, 2:48 AM

	Unknown Object (File)
	Tue, Sep 1, 9:59 PM

	Unknown Object (File)
	Fri, Aug 28, 5:16 AM

Subscribers

Details

Reviewers

bz
kib
gnn

Commits

rS331650: Remove very old and unused signal information codes.

Summary

These have been supplanted by the MI signal information codes in
<sys/signal.h> since 7.0. The FPE_*_TRAP ones were deprecated even
earlier in 1999.

Test Plan

waiting on a tinderbox to finish, but I'm quite certain these aren't used anywhere

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jhb created this revision.Mar 10 2018, 12:03 AM

Harbormaster completed remote builds in B15462: Diff 40120.Mar 10 2018, 12:03 AM

kib added inline comments.Mar 10 2018, 12:30 AM

sys/x86/include/signal.h
48 ↗	(On Diff #40120)	I do not object against this part, but the pollution might be relied upon by third-party software. I do not know.
sys/x86/include/trap.h
88 ↗	(On Diff #40120)	At least BUS_PAGE_FAULT is used in kernel.

jhb added inline comments.Mar 12 2018, 5:17 PM

sys/x86/include/signal.h
48 ↗	(On Diff #40120)	I can request an exp-run to check for this.
sys/x86/include/trap.h
88 ↗	(On Diff #40120)	This is only for legacy binaries though (< 7.0), so I think we can just hide that specific use case under #ifdef _KERNEL. We could also make the tunable depend on #ifdef COMPAT_FREEBSD6? (And just always use SIGSEGV on kernels without COMPAT_FREEBSD6?) Alternatively, the compat shim could just use 'T_PAGEFLT' directly for ucode (this matches what the code did prior to the siginfo commit).

kib added inline comments.Mar 12 2018, 5:38 PM

sys/x86/include/signal.h
48 ↗	(On Diff #40120)	Ok.
sys/x86/include/trap.h
88 ↗	(On Diff #40120)	I do not see a reason to not use T_PAGEFLT directly.

Use T_PAGEFLT directly for the legacy page fault signal code.
Use T_PAGEFLT on i386 as well.
Add <machine/trap.h> #include's.

Harbormaster completed remote builds in B15544: Diff 40252.Mar 13 2018, 4:57 PM

kib accepted this revision.Mar 13 2018, 5:49 PM

This revision is now accepted and ready to land.Mar 13 2018, 5:49 PM

Closed by commit rS331650: Remove very old and unused signal information codes. (authored by jhb). · Explain WhyMar 27 2018, 8:58 PM

This revision was automatically updated to reflect the committed changes.

Herald added a reviewer: gnn. · View Herald TranscriptMar 27 2018, 8:58 PM

Herald added subscribers: rpokala, imp. · View Herald Transcript

Revision Contents
Changeset List

Path

Size

head/

sys/

amd64/

amd64/

5 lines

ia32/

1 line

linux/

1 line

linux32/

linux32_sysvec.c

1 line

cddl/

contrib/

opensolaris/

uts/

intel/

dtrace/

1 line

dev/

dtrace/

amd64/

1 line

i386/

1 line

i386/

i386/

5 lines

linux/

1 line

x86/

include/

4 lines

24 lines

Diff 40821

head/sys/amd64/amd64/trap.c

Loading...

head/sys/amd64/ia32/ia32_signal.c

Loading...

head/sys/amd64/linux/linux_sysvec.c

Loading...

head/sys/amd64/linux32/linux32_sysvec.c

Loading...

head/sys/cddl/contrib/opensolaris/uts/intel/dtrace/fasttrap_isa.c

Loading...

head/sys/cddl/dev/dtrace/amd64/dtrace_subr.c

Loading...

head/sys/cddl/dev/dtrace/i386/dtrace_subr.c

Loading...

head/sys/i386/i386/trap.c

Loading...

head/sys/i386/linux/linux_sysvec.c

Loading...

head/sys/x86/include/signal.h

Loading...

head/sys/x86/include/trap.h

Loading...