Rename kernel-only members of semid_ds and msgid_ds.

[brooks]

Summary

This deliberately breaks the API in preperation for future syscall
revisions which will remove these members.

In an exp-run a single port (qemu-user-static) was found to use them
which it did becuase it emulates system calls. This has been fixed in
the ports tree.

PR: 224443

[kib]

I am fine with the rename. For the action to be more explicit, you might put the fields names into private namespace, prefixing them with '__'.

[jhb]

sys/compat/linux/linux_ipc.c

163

If this represent's Linux's native type then I think we should leave this as-is.

sys/i386/ibcs2/ibcs2_ipc.c

77

The Linux routines don't bother copying these over, so I think we can probably just not bother copying them here either.

sys/i386/ibcs2/ibcs2_ipc.h

48

Likewise if these are native ibcs2 types.

[brooks]

• Don't change the names of members in linux and ibcs.
• Use __foo rather than kfoo for internal members.

[jhb]

sys/kern/sysv_msg.c

1677–1678

Just a note for your next change. If you haven't already done so, it would probably be best if these compat structures are explicitly cleared with 'bzero' or some such before fields are copied over to avoid leaking stack garbage. Right now it probably doesn't matter (though would if there was any padding in the structures), but once the first/last pointers are removed it will presumably matter.

[jhb]

sys/i386/ibcs2/ibcs2_ipc.c

76–78

You need to bzero() or memset() *ibp now to avoid leaking stack garbage after removing these assignments. Sorry I missed that earlier.

[brooks]

• Zero ibp before update to avoid leaking stack garbage.
• Pre-commit rebase.