Page MenuHomeFreeBSD

crossbuild: don't assume <bsd.compiler.mk> always exists
ClosedPublic

Authored by arichardson on Feb 7 2018, 1:11 PM.
Tags
None
Referenced Files
F83041319: D14241.diff
Sun, May 5, 10:42 AM
Unknown Object (File)
Apr 2 2024, 1:13 AM
Unknown Object (File)
Mar 22 2024, 5:17 PM
Unknown Object (File)
Mar 11 2024, 2:00 PM
Unknown Object (File)
Jan 21 2024, 1:23 AM
Unknown Object (File)
Jan 20 2024, 9:26 PM
Unknown Object (File)
Dec 24 2023, 10:01 AM
Unknown Object (File)
Dec 24 2023, 10:01 AM
Subscribers
None

Details

Summary

When crossbuilding e.g. from a Linux system it is not shipped as part of
bmake and will cause the build to fail. I am not sure if it needs to be
included by the toplevel makefile in order for ccache builds to work since
I haven't tested that yet on Linux/Mac.

Another way of solving this could be to required that cross os builds
always set -m $SRCDIR/share/mk but it seems to me like this small change
is simpler.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 14840
Build 14955: arc lint + arc unit

Event Timeline

This revision was not accepted when it landed; it landed in state Needs Review.Feb 7 2018, 4:28 PM
This revision was automatically updated to reflect the committed changes.

I went to add comments to both these locations about why we do odd things with them, and found myself just pulling in the commit to the main tree in r328975. So this review might close automatically.