Page MenuHomeFreeBSD

Don't change directory owner to root when building with -DNO_ROOT
ClosedPublic

Authored by arichardson on Feb 3 2018, 1:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 14, 1:49 AM
Unknown Object (File)
Sun, Oct 12, 7:49 AM
Unknown Object (File)
Tue, Oct 7, 2:42 AM
Unknown Object (File)
Tue, Sep 16, 10:56 PM
Unknown Object (File)
Aug 19 2025, 6:14 PM
Unknown Object (File)
Aug 14 2025, 11:33 PM
Unknown Object (File)
Jul 28 2025, 2:34 PM
Unknown Object (File)
Jul 13 2025, 7:13 PM
Subscribers
None

Details

Summary

Currently the mtree calls in Makefile.inc1 all change the directory owner
to match the spec file. However, we should not be doing this during
distributeworld if -DNO_ROOT is passed. Additionally, when creating the
WORLDTMP directory hierachy there is no need to change the owner to root so
we now always pass the -W flag when populating WORLDTMP.

This is also required for building FreeBSD on Linux/Mac since the required
groups/users will not exist there which is how I discovered this issue.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

LGTM, would like to see ideally @bdrewery but at least someone else agree

This revision is now accepted and ready to land.Feb 7 2018, 1:17 AM

Looks good to me. Thanks for splitting it out. There's no huge rush, so I'd make sure that bdrewery signs off as well.

@bdrewery does this look okay?

Yup. I am flooded with random phab reviews that are not really for me due to ports. Sorry...

This revision was automatically updated to reflect the committed changes.