Page MenuHomeFreeBSD
Differential D13992

Allow ALSA aliases in the Qt5 sound devices list. Patch by Stephen Hurd.
ClosedPublic
Actions

Authored by adridg on Jan 19 2018, 10:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 10, 7:45 AM
Unknown Object (File)
Sat, Nov 8, 8:13 PM
Unknown Object (File)
Tue, Nov 4, 1:57 AM
Unknown Object (File)
Thu, Oct 30, 3:58 AM
Unknown Object (File)
Mon, Oct 27, 8:31 PM
Unknown Object (File)
Sat, Oct 25, 11:04 AM
Unknown Object (File)
Sat, Oct 25, 5:00 AM
Unknown Object (File)
Wed, Oct 22, 1:27 AM
View All Files
Subscribers
mat

Details

Reviewers
tcberner
rakuco
Commits
rP459518: Allow ALSA aliases in the Qt5 sound devices list.
Summary

Build on amd64, run test application from PR208570.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adridg created this revision.Jan 19 2018, 10:40 PM
Herald added a subscriber: mat. · View Herald TranscriptJan 19 2018, 10:40 PM
Harbormaster completed remote builds in B14493: Diff 38227.Jan 19 2018, 10:40 PM
adridg updated this revision to Diff 38228.Jan 19 2018, 10:41 PM

Forgot portrevision bump.

Harbormaster completed remote builds in B14494: Diff 38228.Jan 19 2018, 10:41 PM
tcberner added inline comments.Jan 19 2018, 10:51 PM
multimedia/qt5-multimedia/files/patch-src_plugins_alsa_qalsaaudiodeviceinfo.cpp
1 ↗(On Diff #38228)

^ this belongs into the 'Submitted by'

6 ↗(On Diff #38228)

^ This does not really help to understand what the patch does :)

Stephen's first message in the PR is probably a bit more descriptive:

When using ALSA with FreeBSD, the direct snd_device instances are not available, only plugin devices and "default".  For programs which use QAudio, this means there are *no* devices enumerated using QAudio::availableDevices().

The attached patch adds the aliases to the available device list.
adridg updated this revision to Diff 38232.Jan 19 2018, 11:00 PM

Fix patch so it actually applies.

Harbormaster completed remote builds in B14495: Diff 38232.Jan 19 2018, 11:00 PM
tcberner accepted this revision.Jan 19 2018, 11:31 PM

Looks good, but please include a short description like Stephens' comment atop the patch.

This revision is now accepted and ready to land.Jan 19 2018, 11:31 PM
adridg marked 2 inline comments as done.Jan 20 2018, 12:42 PM
Closed by commit rP459518: Allow ALSA aliases in the Qt5 sound devices list. (authored by adridg). · Explain WhyJan 20 2018, 12:45 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
multimedia/
qt5-multimedia/
2 lines
files/
70 lines

Diff 38247

View Options

head/multimedia/qt5-multimedia/Makefile

Loading...
View Options

head/multimedia/qt5-multimedia/files/patch-src_plugins_alsa_qalsaaudiodeviceinfo.cpp

Loading...