IFLIB: do not remove dmamap on buffer unload
AbandonedPublic
Actions

Authored by wma on Jan 17 2018, 11:42 AM.

Tags

None

Referenced Files

	F152904917: D13950.id38081.diff
	Fri, Apr 17, 10:40 PM

	Unknown Object (File)
	Thu, Apr 16, 12:31 PM

	Unknown Object (File)
	Thu, Apr 16, 5:02 AM

	Unknown Object (File)
	Tue, Apr 14, 4:23 AM

	Unknown Object (File)
	Fri, Apr 3, 4:24 AM

	Unknown Object (File)
	Fri, Apr 3, 1:05 AM

	Unknown Object (File)
	Sat, Mar 28, 12:11 AM

	Unknown Object (File)
	Sat, Mar 28, 12:11 AM

View All 60 Files

Subscribers

Details

Reviewers

shurd
nwhitehorn
jhibbits
mw
imp

Summary

Dmamap is created only on IFC attach. If we remove it on
buffer release, we won't be able to do ifconfig down&up.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

wma created this revision.Jan 17 2018, 11:42 AM

Herald added a subscriber: ae. · View Herald TranscriptJan 17 2018, 11:42 AM

With this change, the RX map is never destroyed. Won't they need to be destroyed in iflib_rx_sds_free() before bus_dma_tag_destroy() is called?

This revision now requires changes to proceed.Jan 22 2018, 7:16 PM

wma abandoned this revision.Jan 26 2018, 7:11 AM

shurd mentioned this in D14060: IFLIB: do not remove dmamap on buffer unload.Jan 26 2018, 6:37 PM

Revision Contents
Changeset List

Path

Size

sys/

net/

iflib.c

1 line

Diff 38081

View Options

IFLIB: do not remove dmamap on buffer unloadAbandonedPublicActions