Add aarch64 patches from Fedora
ClosedPublic
Actions

Authored by adridg on Jan 16 2018, 7:07 PM.

Details

Reviewers

tcberner
rakuco

Group Reviewers

O5: Ports Framework
portmgr

Commits

rP459478: Fix Qt4 atomics on aarch64. Add a patch from Fedora (similar changes in

Summary

Add qatomic for aarch64, based on a Fedora patch. PR 223988

Test Plan

My Pine64+ is still compiling devel/qt4 .. but qt4-dbus does build,
which is what the original PR is about.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adridg created this revision.Jan 16 2018, 7:07 PM

Owners added a reviewer: O5: Ports Framework.Jan 16 2018, 7:07 PM

Herald added a reviewer: portmgr. · View Herald TranscriptJan 16 2018, 7:07 PM

Herald added subscribers: mat, emaste. · View Herald Transcript

Harbormaster completed remote builds in B14417: Diff 38048.Jan 16 2018, 7:07 PM

Sounds good.

adridg mentioned this in D11622: Port devel/qt4-dbus to arm64.Jan 16 2018, 10:35 PM

This has built successfully in a QEMU aarch64 12-CURRENT poudriere and also on a Pine64+; now building on amd64 to check for regressions. I'm a little unclear on the needed PORTREVISION bumps -- only Qt4 Core is directly affected, and Qt4 DBUS didn't compile previously .. I don't know about an effect on dependent ports that did previously compile.

I think it is fine to only bump corelib.

Macro ssshipit: what could go wrong

This revision was not accepted when it landed; it landed in state Needs Review.Jan 19 2018, 10:35 PM

Closed by commit rP459478: Fix Qt4 atomics on aarch64. Add a patch from Fedora (similar changes in (authored by adridg). · Explain Why

This revision was automatically updated to reflect the committed changes.