The qt4 generic atomic operations fail when building for arm64 as they take a void *, but are passed a const QString *. Fix this by casting to a void *.
Details
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
How far do you actually get with the Qt4 ports on arm64? The header you're patching is also used by several other Qt4 ports, as well as ports depending on Qt. Fedora's patch looks quite bigger.
With this and a patch for www/qt4-webkit I can build 106 ports with a name containing qt4 and 1 failure. I don't see the error in any of the failure logs.
What is the status of this?
devel/qt4-dbus/files/patch-src__corelib__arch__qatomic_generic.h | ||
---|---|---|
1 | Could you insert a small comment here ala The qt4 generic atomic operations fail when building for arm64 as they take a void *, but are passed a const QString *. Fix this by casting to a void *. |
I'm trying to crochet a current Pine64 image (and failing). Building ports on NFS with the older Pine64 image is problematic, so this is kind of difficult to test. It *is* somewhere on our radar, though. But .. Qt4 is rather end-of-life, are you sure you want to put effort into fixing it now?
The other review's patches were committed which resolve the issue. Commandeering in order to close.
Could you insert a small comment here ala