Page MenuHomeFreeBSD

devel/pear-SebastianBergmann_PHPLOC: Update and unbreak
ClosedPublic

Authored by joneum on Dec 30 2017, 12:25 AM.

Details

Summary

devel/pear-SebastianBergmann_PHPLOC: Update to 4.0.1

Unbreak this port

Switch to GitHub

Add LICENSE_FILE

Update *_DEPENDS

Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joneum created this revision.Dec 30 2017, 12:25 AM
tcberner added inline comments.Dec 30 2017, 5:48 PM
devel/pear-SebastianBergmann_PHPLOC/Makefile
15 ↗(On Diff #37213)

^ if there is no building done, why do you have BUILD_DEPENDS? [NO_BUILD=YES] -- you probably can get rid of these.

Well, me not noticing it earlier is not an argument for it's correct as it is.

So you think they only release it when it is removed?

So you think they only release it when it is removed?

I don't quite understand what you mean :)

I have to remove it before I become an ok

I have to remove it before I become an ok

I would at least like for you to test if it works without it, yes :)

Then test it :]

tcberner accepted this revision.Dec 30 2017, 8:59 PM
devel/pear-SebastianBergmann_PHPLOC/Makefile
30 ↗(On Diff #37248)

^ there is a tab character after php -- you shouldr remove it before committing

This revision is now accepted and ready to land.Dec 30 2017, 8:59 PM
This revision was automatically updated to reflect the committed changes.