Page MenuHomeFreeBSD
Differential D13687

devel/pear-SebastianBergmann_PHPLOC: Update and unbreak
ClosedPublic
Actions

Authored by joneum on Dec 30 2017, 12:25 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 19, 2:08 PM
Unknown Object (File)
Jan 8 2024, 4:56 AM
Unknown Object (File)
Dec 22 2023, 10:30 PM
Unknown Object (File)
Oct 20 2023, 8:14 AM
Unknown Object (File)
Sep 17 2023, 5:30 AM
Unknown Object (File)
Sep 17 2023, 5:29 AM
Unknown Object (File)
Sep 17 2023, 5:28 AM
Unknown Object (File)
Sep 17 2023, 5:28 AM
View All 21 Files
Subscribers
mat

Details

Reviewers
rene
tcberner
tz
Commits
rP457675: devel/pear-SebastianBergmann_PHPLOC: Update to 4.0.1
Summary

devel/pear-SebastianBergmann_PHPLOC: Update to 4.0.1

Unbreak this port

Switch to GitHub

Add LICENSE_FILE

Update *_DEPENDS

Test Plan

poudriere testport:

#PHP5.6
11.1-amd64
11.1-i386

#PHP7.0
11.1-amd64-PHP70
11.1-i386-PHP70

#PHP7.1
11.1-amd64-PHP71
11.1-i386-PHP71

#PHP7.2
11.1-amd64-PHP72
11.1-i386-PHP72

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13956
Build 14150: arc lint + arc unit

Event Timeline

joneum created this revision.Dec 30 2017, 12:25 AM
Herald added a subscriber: mat. · View Herald TranscriptDec 30 2017, 12:25 AM
Harbormaster completed remote builds in B13935: Diff 37213.Dec 30 2017, 12:25 AM
tcberner added inline comments.Dec 30 2017, 5:48 PM
devel/pear-SebastianBergmann_PHPLOC/Makefile
15–34

^ if there is no building done, why do you have BUILD_DEPENDS? [NO_BUILD=YES] -- you probably can get rid of these.

joneum added inline comments.Dec 30 2017, 5:53 PM
devel/pear-SebastianBergmann_PHPLOC/Makefile
15–34

ähm .....

https://reviews.freebsd.org/D13413
https://reviews.freebsd.org/D13235
https://reviews.freebsd.org/D12892
https://reviews.freebsd.org/D12146
...
...
...

tcberner added a comment.Dec 30 2017, 6:05 PM

Well, me not noticing it earlier is not an argument for it's correct as it is.

joneum added a comment.Dec 30 2017, 6:15 PM

So you think they only release it when it is removed?

tcberner added a comment.Dec 30 2017, 6:25 PM
In D13687#286311, @joneum wrote:

So you think they only release it when it is removed?

I don't quite understand what you mean :)

joneum added a comment.Dec 30 2017, 6:27 PM

I have to remove it before I become an ok

tcberner added a comment.Dec 30 2017, 6:29 PM
In D13687#286321, @joneum wrote:

I have to remove it before I become an ok

I would at least like for you to test if it works without it, yes :)

joneum added a comment.Dec 30 2017, 6:31 PM

Then test it :]

joneum updated this revision to Diff 37248.Dec 30 2017, 8:01 PM

.

Harbormaster completed remote builds in B13956: Diff 37248.Dec 30 2017, 8:01 PM
tcberner accepted this revision.Dec 30 2017, 8:59 PM
devel/pear-SebastianBergmann_PHPLOC/Makefile
30

^ there is a tab character after php -- you shouldr remove it before committing

This revision is now accepted and ready to land.Dec 30 2017, 8:59 PM
Closed by commit rP457675: devel/pear-SebastianBergmann_PHPLOC: Update to 4.0.1 (authored by joneum). · Explain WhyDec 31 2017, 9:22 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
devel/
pear-SebastianBergmann_PHPLOC/
39 lines
5 lines

Diff 37248

View Options

devel/pear-SebastianBergmann_PHPLOC/Makefile

Loading...
View Options

devel/pear-SebastianBergmann_PHPLOC/distinfo

Loading...