Help find Boost
Needs ReviewPublic

Authored by adridg on Thu, Dec 28, 2:34 PM.

Details

Reviewers
tcberner
jbeich
Summary

Allow newer Boost 1.66 to use CMake importerd targets.

Diff Detail

Lint
No Linters Available
Unit
No Unit Test Coverage
Build Status
Buildable 14098
Build 14276: arc lint + arc unit
adridg created this revision.Thu, Dec 28, 2:34 PM

I think this needs an exp-run together with boost updated to 1.66.

adridg updated this revision to Diff 37178.Fri, Dec 29, 1:44 PM

While here, also add c++11-lang as requirement.

devel/cmake/Makefile
23

With respect to
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224721
can you put this in a separate revision, so we can fix it quickly?

adridg marked an inline comment as done.Sat, Dec 30, 1:29 PM
adridg added inline comments.
devel/cmake/Makefile
23

Exp-run requested for PR 224721. See also https://reviews.freebsd.org/D13694

adridg updated this revision to Diff 37256.Sat, Dec 30, 10:53 PM
adridg marked an inline comment as done.

C++11 stuff has already been committed, so just leave the imported target fix

jbeich added a subscriber: jbeich.Sat, Dec 30, 11:16 PM

C++11 stuff has already been committed, so just leave the imported target fix

C++11 change didn't need PORTREVISION bump unlike FindBoost. Can you bump it again?

jbeich requested changes to this revision.Mon, Jan 1, 9:26 PM

Without PORTREVISION bump exp-run may not rebuild devel/cmake, so net/ceph is likely show up as false positive.

This revision now requires changes to proceed.Mon, Jan 1, 9:26 PM
jbeich updated this revision to Diff 37488.Thu, Jan 4, 12:26 AM
  • Bump PORTREVISION
  • Regen patch via make makepatch
jbeich accepted this revision.Thu, Jan 4, 12:26 AM
This revision is now accepted and ready to land.Thu, Jan 4, 12:26 AM
jbeich resigned from this revision.Thu, Jan 4, 12:27 AM
This revision now requires review to proceed.Thu, Jan 4, 12:27 AM