Page MenuHomeFreeBSD
Differential D13662

Help find Boost
ClosedPublic
Actions

Authored by adridg on Dec 28 2017, 2:34 PM.
Tags
None
Referenced Files
F81586765: D13662.diff
Thu, Apr 18, 1:23 PM
Unknown Object (File)
Wed, Apr 17, 9:49 PM
Unknown Object (File)
Fri, Apr 12, 10:49 AM
Unknown Object (File)
Fri, Apr 12, 10:49 AM
Unknown Object (File)
Fri, Apr 12, 10:49 AM
Unknown Object (File)
Fri, Apr 12, 10:49 AM
Unknown Object (File)
Fri, Apr 12, 10:49 AM
Unknown Object (File)
Fri, Apr 12, 10:49 AM
View All 79 Files
Subscribers
jbeich
mat

Details

Reviewers
tcberner
jbeich
Commits
rP459314: devel/cmake: unbreak net/ceph with boost 1.66
Summary

Allow newer Boost 1.66 to use CMake importerd targets.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

adridg created this revision.Dec 28 2017, 2:34 PM
Herald added a subscriber: mat. · View Herald TranscriptDec 28 2017, 2:34 PM
Harbormaster completed remote builds in B13891: Diff 37134.Dec 28 2017, 2:34 PM
tcberner added a comment.Dec 28 2017, 7:39 PM

I think this needs an exp-run together with boost updated to 1.66.

adridg updated this revision to Diff 37178.Dec 29 2017, 1:44 PM

While here, also add c++11-lang as requirement.

Harbormaster completed remote builds in B13917: Diff 37178.Dec 29 2017, 1:44 PM
tcberner added a comment.Dec 30 2017, 9:48 AM
devel/cmake/Makefile
23 ↗(On Diff #37178)

With respect to
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224721
can you put this in a separate revision, so we can fix it quickly?

adridg marked an inline comment as done.Dec 30 2017, 1:29 PM
adridg added inline comments.
devel/cmake/Makefile
23 ↗(On Diff #37178)

Exp-run requested for PR 224721. See also https://reviews.freebsd.org/D13694

jbeich added a child revision: D13279: devel/boost-*: update to 1.66.0.Dec 30 2017, 9:50 PM
adridg updated this revision to Diff 37256.Dec 30 2017, 10:53 PM
adridg marked an inline comment as done.

C++11 stuff has already been committed, so just leave the imported target fix

jbeich added a child revision: D13699: Upgrade net/ceph to version 12.2.2.Dec 30 2017, 11:14 PM
jbeich added a subscriber: jbeich.Dec 30 2017, 11:16 PM
In D13662#286443, @adridg wrote:

C++11 stuff has already been committed, so just leave the imported target fix

C++11 change didn't need PORTREVISION bump unlike FindBoost. Can you bump it again?

jbeich removed a child revision: D13699: Upgrade net/ceph to version 12.2.2.Dec 31 2017, 3:08 AM
jbeich requested changes to this revision.Jan 1 2018, 9:26 PM

Without PORTREVISION bump exp-run may not rebuild devel/cmake, so net/ceph is likely show up as false positive.

This revision now requires changes to proceed.Jan 1 2018, 9:26 PM
jbeich updated this revision to Diff 37488.Jan 4 2018, 12:26 AM
  • Bump PORTREVISION
  • Regen patch via make makepatch
jbeich accepted this revision.Jan 4 2018, 12:26 AM
This revision is now accepted and ready to land.Jan 4 2018, 12:26 AM
jbeich resigned from this revision.Jan 4 2018, 12:27 AM
This revision now requires review to proceed.Jan 4 2018, 12:27 AM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 18 2018, 4:01 AM
Closed by commit rP459314: devel/cmake: unbreak net/ceph with boost 1.66 (authored by jbeich). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
devel/
cmake/
2 lines
files/
12 lines

Diff 38126

View Options

head/devel/cmake/Makefile

Loading...
View Options

head/devel/cmake/files/patch-Modules_FindBoost.cmake

Loading...