Page MenuHomeFreeBSD

recognize a pending virtual interrupt while emulating halt instruction
ClosedPublic

Authored by tychon on Dec 21 2017, 3:40 PM.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

tychon created this revision.Dec 21 2017, 3:40 PM
rgrimes added inline comments.Dec 21 2017, 4:11 PM
sys/amd64/vmm/intel/vmx.c
3190 ↗(On Diff #36864)

Do we need to do some .h work, seems you use this magic constant 0xf0 twice here, for me that means it probably should be a #define that is descriptive of what bits are being masked?

tychon updated this revision to Diff 36870.Dec 21 2017, 5:26 PM

Replace magic constants with #define, within the function, to clarify usage.

grehan accepted this revision.Dec 21 2017, 6:10 PM
This revision is now accepted and ready to land.Dec 21 2017, 6:10 PM
rgrimes accepted this revision.
This revision was automatically updated to reflect the committed changes.