Page MenuHomeFreeBSD

recognize a pending virtual interrupt while emulating halt instruction
ClosedPublic

Authored by tychon on Dec 21 2017, 3:40 PM.
Tags
None
Referenced Files
F168137139: D13573.diff
Wed, Aug 26, 1:23 PM
F168069705: D13573.id36872.diff
Wed, Aug 26, 5:54 AM
F168058113: D13573.id36864.diff
Wed, Aug 26, 4:26 AM
F168000771: D13573.id36864.diff
Tue, Aug 25, 8:44 PM
Unknown Object (File)
Tue, Aug 25, 6:49 AM
Unknown Object (File)
Mon, Aug 24, 12:55 PM
Unknown Object (File)
Sun, Aug 23, 2:39 PM
Unknown Object (File)
Sat, Aug 22, 4:43 PM
Subscribers

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

sys/amd64/vmm/intel/vmx.c
3190 ↗(On Diff #36864)

Do we need to do some .h work, seems you use this magic constant 0xf0 twice here, for me that means it probably should be a #define that is descriptive of what bits are being masked?

Replace magic constants with #define, within the function, to clarify usage.

This revision is now accepted and ready to land.Dec 21 2017, 6:10 PM
This revision was automatically updated to reflect the committed changes.