This is the discussed patch with ops renamed (_relaxed removed). The documentation was stripped as well, the operations are explained in D13522.
Details
Details
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
sys/vm/uma_core.c | ||
---|---|---|
3173 ↗ | (On Diff #36715) | I would suggest using atomic_load() here so that all accesses to this variable are made with explicit atomics. Or else, don't use atomic_store() below. In other words, I don't see an argument for using store below but not using load here. |
Comment Actions
I'm happy with the implementation. (I assume that the use cases will be committed separately.)
sys/vm/uma_core.c | ||
---|---|---|
3173 ↗ | (On Diff #36717) | atomic_load_int? |
Comment Actions
With the caveat of fixing the atomic_load -> atomic_load_int alc@ already noted. Thanks for doing this.