Remove support for variables that have been deprecated for a while.

[mat]

Summary

To be exact:

variable	deprecation added	revision	planned expiration date
WITHOUT_NLS	2013-12-13	rP336337
WITH_/WITHOUT_	2014-02-24	rP345870
NOPORTDOCS/NOPORTEXAMPLES	2014-04-19	rP351587
WITH_BDB_VER	2016-05-02	rP414444	2016-08-01
OVERRIDE_LINUX_BASE_PORT	2016-09-05	rP421387
WITH_OPENSSL_	2016-06-16	rP416965

Test Plan

I expect a big fallout from removing the way PORTDOCS/PORTEXAMPLES work, but it is unavoidable, and easily fixed.

[mat]

• Of course, someone did that.
• Also remove WITH_/WITHOUT_ support as I said.

[mat]

• Add a WARNING about the WITH_/WITHOUT_.

[mat]

• Make it more clear.

[mat]

• Make it actually work.

[mat]

• Add WITH_BDB_VER to the list of removed stuff.

[mat]

• OVERRIDE_LINUX_BASE_PORT.
• WITH_OPENSSL_*

[bapt]

I expect fallouts so some exp-run would be nice.
Part of this can be committed right now already.

chinese/libtabe/Makefile

48

Can be committed now :)

chinese/p5-Lingua-ZH-TaBE/Makefile

37

This can be committed separatly as in now :)

databases/ruby-bdb/Makefile

12

Can be committed now :)

www/rubygem-passenger/Makefile

47

Can be committed now :)

[mat]

In D13490#281980, @bapt wrote:

I expect fallouts so some exp-run would be nice.

Well, I was expecting fallout, but %%PORTDOCS%% and %%PORTEXAMPLES%% work by looking if the option is there, not if the option really exists. I'll patch it a bit more.

[mat]

• There was a hidden NOPORTxxx here.
• Only set PORTDOCS/PORTEXAMPLES if their respective options are in OPTIONS_DEFINE.

[mat]

Ok, so with the latest patch, things error out with a:

===> Checking for items in STAGEDIR missing from pkg-plist
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/3.4.0_to_4.1.0_schema.pgsql.sql
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/dnssec-3.x_to_3.4.0_schema.pgsql.sql
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/nodnssec-3.x_to_3.4.0_schema.pgsql.sql
Error: Orphaned: %%PORTDOCS%%%%DOCSDIR%%/schema.pgsql.sql
Error: Orphaned: %%PORTEXAMPLES%%%%EXAMPLESDIR%%/pdns.conf
===> Checking for items in pkg-plist which are not in STAGEDIR
Error: Missing: %%PORTDOCS%%%%DOCSDIR%%/3.4.0_to_4.1.0_schema.pgsql.sql
Error: Missing: %%PORTDOCS%%%%DOCSDIR%%/dnssec-3.x_to_3.4.0_schema.pgsql.sql
Error: Missing: %%PORTDOCS%%%%DOCSDIR%%/nodnssec-3.x_to_3.4.0_schema.pgsql.sql
Error: Missing: %%PORTDOCS%%%%DOCSDIR%%/schema.pgsql.sql
Error: Missing: %%PORTEXAMPLES%%@dir %%EXAMPLESDIR%%
Error: Missing: %%PORTEXAMPLES%%%%EXAMPLESDIR%%/pdns.conf

Which is going to get some wtf from people :-)

[eadler]

LGTM overall

Mk/bsd.sanity.mk

5–15

eh, I'd just remove this. years of warnings is enough

[bapt]

Mk/bsd.sanity.mk

5–15

I disagree we should say it is unsupported and even maybe replace the WARNING with an ERROR imho.

Poisonning variables that used to be documented and used for a while is very important. Lots of old documentation are still available online, on random blogs etc.

[adamw]

Mk/bsd.sanity.mk

5–15

@eadler: Join ports@ and answer the same question over and over again and you'll see why error conditions need to be spelled out explicitly :-)

[mat]

Mk/bsd.sanity.mk

5–15

I was considering adding an ERROR variable, maybe I will, to make sure people update their systems.

[mat]

Remove the last commit, it'll be done in a different review.

[mat]

rebase.

[mat]

• Move WARNING to b.sanity.m.

[mat]

• Add a show-error target that, well, show errors, and move NOPORTDOCS,

[mat]

• These are actually user facing variables, not dev ones.

[mat]

• correct target name.
• A bit more verbose about what to do.

[mat]

• This is not needed.

[mat]

• Make this an error too.

[mat]

• Remove this line.

[mat]

• Cleanup bsd.sanity.mk a bit more.

[mat]

• Fix fallout.