Page MenuHomeFreeBSD

Add FLAVOR support for ruby- ports
Needs ReviewPublic

Authored by swills on Dec 2 2017, 3:32 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 8:24 PM
Unknown Object (File)
Fri, Apr 12, 9:11 PM
Unknown Object (File)
Fri, Apr 12, 7:24 PM
Unknown Object (File)
Fri, Apr 12, 7:24 PM
Unknown Object (File)
Fri, Apr 12, 5:48 PM
Unknown Object (File)
Fri, Apr 12, 2:15 PM
Unknown Object (File)
Fri, Apr 12, 2:13 PM
Unknown Object (File)
Wed, Apr 10, 5:46 PM

Details

Reviewers
None
Group Reviewers
portmgr
Summary

Add support to bsd.ruby.mk for FLAVORS of ruby- ports. Note that flavors for
rubygem- ports are separate, although this does add flavors for devel/ruby-gems
as both an example and prerequisite for rubygem- FLAVORS.

Test Plan

Manual testing

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13259
Build 13496: arc lint + arc unit

Event Timeline

Minor fixup and add support for rubygem- flavors

Check USES is set before referencing it

Remove USES check since it breaks index

devel/ruby-gems/Makefile
63–67

This could probably be better handled with USES=uniquefiles, no ?

swills added inline comments.
devel/ruby-gems/Makefile
63–67

After discussion elsewhere (irc), uniquefiles doesn't seem like the right solution here.

This is work in progress at the moment. The ruby- flavors seem fine. Started on the rubygem- flavors, but am running into an issue. I started with devel/rubygem-glib2 as an example port to test the deps. All the flavors of devel/rubygem-pkg-config build fine on all versions. The issue I'm running into is that for devel/rubygem-native-package-installer, the rubygem24 and rubygem26 flavors fail on 11.2 in poudriere. The issue seems to be an error with make, tho I'm not sure as it's hard to track down. I'll do some more testing, but wanted to share what I've done so far for others to review.