Page MenuHomeFreeBSD

Fix default numbers of queue sets
ClosedPublic

Authored by shurd on Nov 14 2017, 9:52 PM.

Details

Summary

The intent appears to be having one RX/TX queue set per core,
but since scctx->isc_n[tr]xqsets is set to max before calling
iflib_msix_init(), both end up being set to total number of cores.

Use ctx->ifc_sysctl_n[rt]xqs as the selected value and
scctx->isc_n[rt]xqsets as the max. This should result in what appears
to be the intended behaviour

Test Plan

Ensure default queues is number of cores across multiple
systems, and verify that override works as wxpected.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

shurd created this revision.Nov 14 2017, 9:52 PM
sbruno accepted this revision.Nov 15 2017, 3:55 PM
This revision is now accepted and ready to land.Nov 15 2017, 3:56 PM
This revision was automatically updated to reflect the committed changes.