Page MenuHomeFreeBSD

bhargava.marreddy_broadcom.com (BHARGAVA CHENNA MARREDDY)
User

Projects

User does not belong to any projects.

User Details

User Since
May 4 2017, 8:38 AM (84 w, 2 d)

Recent Activity

May 18 2018

bhargava.marreddy_broadcom.com retitled D15466: bnxt: Fix HWRM warning messages during HW LRO configuration. from bnxt: Suppress HWRM warning messages during HW LRO configuration. to bnxt: Fix HWRM warning messages during HW LRO configuration..
May 18 2018, 1:47 AM

May 17 2018

bhargava.marreddy_broadcom.com added a reviewer for D15466: bnxt: Fix HWRM warning messages during HW LRO configuration.: sbruno.
May 17 2018, 5:38 PM
bhargava.marreddy_broadcom.com created D15466: bnxt: Fix HWRM warning messages during HW LRO configuration..
May 17 2018, 5:36 PM

May 4 2018

bhargava.marreddy_broadcom.com accepted D15143: MFC bnxt changes to 11-STABLE.

I have tested this patch on local setup, basic I/O is running fine.

May 4 2018, 12:03 PM

Feb 6 2018

bhargava.marreddy_broadcom.com added inline comments to D13982: bnxt: Update man page with newly supported devices, options, ect.
Feb 6 2018, 12:29 PM
bhargava.marreddy_broadcom.com updated the diff for D13982: bnxt: Update man page with newly supported devices, options, ect.

Taken care of all review comments.

Feb 6 2018, 12:24 PM

Jan 30 2018

bhargava.marreddy_broadcom.com added inline comments to D13982: bnxt: Update man page with newly supported devices, options, ect.
Jan 30 2018, 7:23 AM

Jan 19 2018

bhargava.marreddy_broadcom.com updated the summary of D13982: bnxt: Update man page with newly supported devices, options, ect.
Jan 19 2018, 12:36 PM
bhargava.marreddy_broadcom.com created D13982: bnxt: Update man page with newly supported devices, options, ect.
Jan 19 2018, 12:32 PM

Dec 4 2017

bhargava.marreddy_broadcom.com added a comment to D12973: bnxt: While VLAN TCP Tx is progress, "ifconfig destroy" caused kernel Crash in Iflib code.

Matt Joras, Sean Bruno, Stephen Hurd,

Dec 4 2017, 1:02 PM
bhargava.marreddy_broadcom.com abandoned D12897: bnxt: Workaround for ifconfig showing media as 'Other'.
Dec 4 2017, 11:11 AM
bhargava.marreddy_broadcom.com added a comment to D12897: bnxt: Workaround for ifconfig showing media as 'Other'.

So with D13312 committed, is there still a need for a change? If not, please abandon this review.

Verified the change with D13312 alone, it seems to be working fine, I can abandon this now. Thank you!!

Dec 4 2017, 11:11 AM
bhargava.marreddy_broadcom.com updated the diff for D13269: bnxt: Add SR-IOV support for Stratus 100G NIC.

bnxt: Removed Tx padding logic from earlier patch

since iflib supporting it as part of D13324.
Dec 4 2017, 10:03 AM
bhargava.marreddy_broadcom.com accepted D13324: Add support to pad Ethernet frames to a minimum size.
Dec 4 2017, 8:43 AM
bhargava.marreddy_broadcom.com added a comment to D13324: Add support to pad Ethernet frames to a minimum size.

Thanks to Stephen,
Tested with Cumulus A0 NIC, test passed with this patch.
I'll delete the old workaround (used for padding) from driver.

Dec 4 2017, 8:43 AM

Dec 1 2017

bhargava.marreddy_broadcom.com accepted D13312: Add support for SIOCGIFXMEDIA to iflib.
Dec 1 2017, 5:47 PM
bhargava.marreddy_broadcom.com added a comment to D13269: bnxt: Add SR-IOV support for Stratus 100G NIC.

How are you testing this padding?

<Chenna> ARP response pkt is less than 60 bytes, right? I'm able to repro using ARP response pkt only.

Dec 1 2017, 2:35 AM

Nov 30 2017

bhargava.marreddy_broadcom.com added a comment to D12897: bnxt: Workaround for ifconfig showing media as 'Other'.

Please ignore Crash as that is not related to this particulate issue.

Nov 30 2017, 2:05 PM
bhargava.marreddy_broadcom.com added inline comments to D13269: bnxt: Add SR-IOV support for Stratus 100G NIC.
Nov 30 2017, 9:27 AM

Nov 27 2017

bhargava.marreddy_broadcom.com updated the summary of D13269: bnxt: Add SR-IOV support for Stratus 100G NIC.
Nov 27 2017, 3:15 PM
bhargava.marreddy_broadcom.com added a comment to D12897: bnxt: Workaround for ifconfig showing media as 'Other'.

Hi Stephen,

Nov 27 2017, 3:10 PM
bhargava.marreddy_broadcom.com added reviewers for D13269: bnxt: Add SR-IOV support for Stratus 100G NIC: siva.kallam_broadcom.com, sbruno.
Nov 27 2017, 2:32 PM
bhargava.marreddy_broadcom.com added a comment to D13269: bnxt: Add SR-IOV support for Stratus 100G NIC.
  1. Added support for Short-HWRM since it is required for stratus to support SR-IOV
  2. Since few BRCM A0 NICs can not handle < 52 byte Tx pkts, implemented padding logic.
  3. Taken care of other minor issues while claiming VFs.
Nov 27 2017, 2:31 PM
bhargava.marreddy_broadcom.com created D13269: bnxt: Add SR-IOV support for Stratus 100G NIC.
Nov 27 2017, 2:25 PM

Nov 16 2017

bhargava.marreddy_broadcom.com added a comment to D12973: bnxt: While VLAN TCP Tx is progress, "ifconfig destroy" caused kernel Crash in Iflib code.

Matt Joras,

Nov 16 2017, 7:13 AM

Nov 15 2017

bhargava.marreddy_broadcom.com accepted D13096: Fix default numbers of queue sets.
Nov 15 2017, 4:09 PM

Nov 8 2017

bhargava.marreddy_broadcom.com accepted D12976: Fix issue with VXLAN-encapsulated rx h/w checksum.
Nov 8 2017, 3:14 AM
bhargava.marreddy_broadcom.com added a comment to D12976: Fix issue with VXLAN-encapsulated rx h/w checksum.

Looks good to me.

Nov 8 2017, 3:14 AM

Nov 7 2017

bhargava.marreddy_broadcom.com created D12973: bnxt: While VLAN TCP Tx is progress, "ifconfig destroy" caused kernel Crash in Iflib code.
Nov 7 2017, 3:51 PM
bhargava.marreddy_broadcom.com added a comment to D12897: bnxt: Workaround for ifconfig showing media as 'Other'.

Thanks Stephen,

Nov 7 2017, 3:51 PM

Nov 3 2017

bhargava.marreddy_broadcom.com added a comment to D12897: bnxt: Workaround for ifconfig showing media as 'Other'.

Quick update:-

Nov 3 2017, 2:17 PM
bhargava.marreddy_broadcom.com updated the diff for D12896: bnxt: Add support for new phy_types and speeds - Part #2.

I agree with you!! Thanks for the suggestion.

Nov 3 2017, 1:19 PM

Nov 1 2017

bhargava.marreddy_broadcom.com added a comment to D12897: bnxt: Workaround for ifconfig showing media as 'Other'.

Problem description:-
Ifconfig showing media as 'Other' only for bnxt interfaces, where as for ix1 (Intel 10G NIC) it is showing properly.

Nov 1 2017, 11:51 AM
bhargava.marreddy_broadcom.com created D12897: bnxt: Workaround for ifconfig showing media as 'Other'.
Nov 1 2017, 11:46 AM
bhargava.marreddy_broadcom.com added reviewers for D12896: bnxt: Add support for new phy_types and speeds - Part #2: siva.kallam_broadcom.com, sbruno.
Nov 1 2017, 10:51 AM
bhargava.marreddy_broadcom.com created D12896: bnxt: Add support for new phy_types and speeds - Part #2.
Nov 1 2017, 10:51 AM

Oct 27 2017

bhargava.marreddy_broadcom.com added a comment to D12423: bnxt: Add support for new phy_types and speeds.

For now, taken care of all of your review comments, I'm sorry for couple of duplicate entries / incompatible entries in earlier patch.

Oct 27 2017, 9:09 AM
bhargava.marreddy_broadcom.com updated the diff for D12423: bnxt: Add support for new phy_types and speeds.

Taken care of all review comments.

Oct 27 2017, 9:04 AM
bhargava.marreddy_broadcom.com added inline comments to D12423: bnxt: Add support for new phy_types and speeds.
Oct 27 2017, 7:24 AM
bhargava.marreddy_broadcom.com added inline comments to D12774: bnxt: HW_LRO Rx Pkt with > 32 fragments caused Crash (iflib).
Oct 27 2017, 6:17 AM
bhargava.marreddy_broadcom.com updated the diff for D12774: bnxt: HW_LRO Rx Pkt with > 32 fragments caused Crash (iflib).

Taken care of review comments.

Oct 27 2017, 6:16 AM

Oct 25 2017

bhargava.marreddy_broadcom.com updated the diff for D12774: bnxt: HW_LRO Rx Pkt with > 32 fragments caused Crash (iflib).

Modify IFLIB_MAX_RX_SEGS to 66 which is theoretical maximum for BRCM NIC (64 + 1 TPA_START + 1 TPA_END)

Oct 25 2017, 8:34 AM
bhargava.marreddy_broadcom.com added a comment to D12774: bnxt: HW_LRO Rx Pkt with > 32 fragments caused Crash (iflib).

How many are required when max_agg_segs == 7? With that value change in future hardware designs?

Though I'm seeing max of 45 in my setup, Theoretical max num_frags is 66 (64 frags + 1 TPA_Start + 1 TPA_End).

Oct 25 2017, 8:31 AM

Oct 24 2017

bhargava.marreddy_broadcom.com updated the diff for D12599: bnxt: Add support for Flow control setting using sysctl.

Taken care of review comments.

Oct 24 2017, 4:30 PM
bhargava.marreddy_broadcom.com added inline comments to D12599: bnxt: Add support for Flow control setting using sysctl.
Oct 24 2017, 2:05 PM
bhargava.marreddy_broadcom.com updated the diff for D12423: bnxt: Add support for new phy_types and speeds.

Taken care of review comments.

Oct 24 2017, 1:41 PM
bhargava.marreddy_broadcom.com added inline comments to D12423: bnxt: Add support for new phy_types and speeds.
Oct 24 2017, 1:40 PM
bhargava.marreddy_broadcom.com created D12774: bnxt: HW_LRO Rx Pkt with > 32 fragments caused Crash (iflib).
Oct 24 2017, 1:28 PM

Oct 17 2017

bhargava.marreddy_broadcom.com added a comment to D12599: bnxt: Add support for Flow control setting using sysctl.

Can you please review the patch and commit if no changes required?

Oct 17 2017, 11:44 AM
bhargava.marreddy_broadcom.com added a comment to D12423: bnxt: Add support for new phy_types and speeds.

Thank you, Stephen.

Oct 17 2017, 5:56 AM

Oct 6 2017

bhargava.marreddy_broadcom.com added a comment to D12423: bnxt: Add support for new phy_types and speeds.

Trimmed switch-case block a lot and allowing a speed only when it is supported by it's phy_type.
Can you please review and let me know if still there are any issues?

Oct 6 2017, 2:33 PM
bhargava.marreddy_broadcom.com added inline comments to D12423: bnxt: Add support for new phy_types and speeds.
Oct 6 2017, 2:26 PM
bhargava.marreddy_broadcom.com updated the diff for D12423: bnxt: Add support for new phy_types and speeds.

Taken care of Stephen's review comments by removing speed / phy_type combinations which doesn't exist currently or technically not possible.

Oct 6 2017, 2:18 PM
bhargava.marreddy_broadcom.com updated the diff for D12599: bnxt: Add support for Flow control setting using sysctl.

Fixed issue of double notification (in the kernel logs) after changing flow control setting in case of pause_autoneg.

Oct 6 2017, 7:26 AM
bhargava.marreddy_broadcom.com created D12599: bnxt: Add support for Flow control setting using sysctl.
Oct 6 2017, 6:27 AM

Sep 28 2017

bhargava.marreddy_broadcom.com added a comment to D12423: bnxt: Add support for new phy_types and speeds.

Thanks for the review, Stephen.

Sep 28 2017, 6:12 PM
bhargava.marreddy_broadcom.com added a comment to D12223: bnxt: Choose correct Firmware options of HW LRO for best performance.

Hi Stephen,

Sep 28 2017, 5:55 PM
bhargava.marreddy_broadcom.com created D12527: bnxt: intermittently VLAN ping doesn't work .
Sep 28 2017, 10:55 AM

Sep 25 2017

bhargava.marreddy_broadcom.com added a comment to D12436: Improved logging of gtaskqueue failues.

Hi Stephen,

Sep 25 2017, 1:53 PM
bhargava.marreddy_broadcom.com added a comment to D12223: bnxt: Choose correct Firmware options of HW LRO for best performance.

Hi Stephen,

Sep 25 2017, 11:42 AM

Sep 22 2017

bhargava.marreddy_broadcom.com updated the diff for D12223: bnxt: Choose correct Firmware options of HW LRO for best performance.

Looks good, though the other one should be renamed as well.

<Chenna> Taken care!!

Sep 22 2017, 6:54 AM

Sep 21 2017

bhargava.marreddy_broadcom.com updated the diff for D12223: bnxt: Choose correct Firmware options of HW LRO for best performance.

Thanks Stephen,

Sep 21 2017, 1:55 PM
bhargava.marreddy_broadcom.com added a comment to D12423: bnxt: Add support for new phy_types and speeds.

Thank you for the review, Stephen. Please find my response below.

Sep 21 2017, 12:42 PM

Sep 20 2017

bhargava.marreddy_broadcom.com created D12423: bnxt: Add support for new phy_types and speeds.
Sep 20 2017, 2:29 PM

Sep 18 2017

bhargava.marreddy_broadcom.com added inline comments to D12223: bnxt: Choose correct Firmware options of HW LRO for best performance.
Sep 18 2017, 4:43 PM
bhargava.marreddy_broadcom.com added inline comments to D12223: bnxt: Choose correct Firmware options of HW LRO for best performance.
Sep 18 2017, 4:40 PM
bhargava.marreddy_broadcom.com updated the diff for D12223: bnxt: Choose correct Firmware options of HW LRO for best performance.

Not really. It's easiest/best to make it only modifiable when !(if_getdrvflags() & IFF_DRV_RUNNING)

<Chenna> Taken care!!

Sep 18 2017, 4:38 PM

Sep 14 2017

bhargava.marreddy_broadcom.com added a comment to D12223: bnxt: Choose correct Firmware options of HW LRO for best performance.

I need some more time to get back on 'default hw_lro options' / ip_forwarding.

Sep 14 2017, 1:48 PM

Sep 13 2017

bhargava.marreddy_broadcom.com requested changes to D12235: iflib rollup patch..
Sep 13 2017, 2:33 PM
bhargava.marreddy_broadcom.com added a reviewer for D12235: iflib rollup patch.: bhargava.marreddy_broadcom.com.
Sep 13 2017, 2:33 PM
bhargava.marreddy_broadcom.com added a comment to D12235: iflib rollup patch..

Looks like this patch causing issues with bnxt driver unload.

Sep 13 2017, 2:21 PM

Sep 8 2017

bhargava.marreddy_broadcom.com added a comment to D12223: bnxt: Choose correct Firmware options of HW LRO for best performance.

Stephen,

Please find my few inline explanations which may helps in the review.
Sep 8 2017, 1:40 PM
bhargava.marreddy_broadcom.com added a comment to D12223: bnxt: Choose correct Firmware options of HW LRO for best performance.

Thank you, Stephen.

Sep 8 2017, 1:34 PM
bhargava.marreddy_broadcom.com updated the diff for D12223: bnxt: Choose correct Firmware options of HW LRO for best performance.

Taken care of review comments.

Sep 8 2017, 1:31 PM
bhargava.marreddy_broadcom.com added a comment to D11914: Bnxt: Add support for displaying Hardware port queue stats using sysctl..

Thanks a lot, Stephen.

Sep 8 2017, 1:28 PM

Sep 7 2017

bhargava.marreddy_broadcom.com added a comment to D12223: bnxt: Choose correct Firmware options of HW LRO for best performance.
when using iflib, software LRO is handled by iflib, not through the driver using tcp_lro_rx()/tcp_lro_flush_all().

<Chenna> Thanks for the info.

Sep 7 2017, 1:05 PM
bhargava.marreddy_broadcom.com added a comment to D11914: Bnxt: Add support for displaying Hardware port queue stats using sysctl..

Taken care of all review comments.

Sep 7 2017, 6:50 AM
bhargava.marreddy_broadcom.com added inline comments to D11914: Bnxt: Add support for displaying Hardware port queue stats using sysctl..
Sep 7 2017, 6:48 AM
bhargava.marreddy_broadcom.com updated the diff for D11914: Bnxt: Add support for displaying Hardware port queue stats using sysctl..

Taken care of all review comments.

Sep 7 2017, 6:47 AM

Sep 6 2017

bhargava.marreddy_broadcom.com updated the diff for D11914: Bnxt: Add support for displaying Hardware port queue stats using sysctl..

Corrected patch by removing debug code.

Sep 6 2017, 4:56 PM
bhargava.marreddy_broadcom.com updated the diff for D11914: Bnxt: Add support for displaying Hardware port queue stats using sysctl..

Combining them into one allocation seems like a needlessly awkward way to save 4k.

<Chenna> I agree with this, separated the allocations.

Sep 6 2017, 4:52 PM
bhargava.marreddy_broadcom.com added a comment to D12203: bnxt: Update firmware header file with the latest one.

Sean Bruno,

Sep 6 2017, 8:55 AM
bhargava.marreddy_broadcom.com added a comment to D12203: bnxt: Update firmware header file with the latest one.

Thanks Stephen, Already opened a mail thread with Firmware team regarding that and will update the status once get back.

Sep 6 2017, 8:53 AM

Sep 5 2017

bhargava.marreddy_broadcom.com added a comment to D12223: bnxt: Choose correct Firmware options of HW LRO for best performance.

Thanks a lot for such detailed explanation, It really helped me for better understanding.

Sep 5 2017, 2:49 PM
bhargava.marreddy_broadcom.com added a comment to D12223: bnxt: Choose correct Firmware options of HW LRO for best performance.

Thank you, Stephen.

Sep 5 2017, 7:32 AM

Sep 4 2017

bhargava.marreddy_broadcom.com retitled D12223: bnxt: Choose correct Firmware options of HW LRO for best performance from bnxt: Choose correct Firmware options for HW LRO for best performance to bnxt: Choose correct Firmware options of HW LRO for best performance.
Sep 4 2017, 2:06 PM
bhargava.marreddy_broadcom.com created D12223: bnxt: Choose correct Firmware options of HW LRO for best performance.
Sep 4 2017, 2:05 PM
bhargava.marreddy_broadcom.com updated the diff for D12203: bnxt: Update firmware header file with the latest one.
Sep 4 2017, 11:18 AM
bhargava.marreddy_broadcom.com added inline comments to D12203: bnxt: Update firmware header file with the latest one.
Sep 4 2017, 11:17 AM

Sep 1 2017

bhargava.marreddy_broadcom.com created D12203: bnxt: Update firmware header file with the latest one.
Sep 1 2017, 11:33 AM

Aug 31 2017

bhargava.marreddy_broadcom.com added inline comments to D11914: Bnxt: Add support for displaying Hardware port queue stats using sysctl..
Aug 31 2017, 4:48 PM
bhargava.marreddy_broadcom.com added a comment to D12128: bnxt: Use correct firmware ioctl to get number of Rx/Tx queues supported by firmware.

You should update the summary to remove item #2 so it's useful as a commit message.

<Chenna> Done!!

Aug 31 2017, 2:49 PM
bhargava.marreddy_broadcom.com updated the summary of D12128: bnxt: Use correct firmware ioctl to get number of Rx/Tx queues supported by firmware.
Aug 31 2017, 2:48 PM

Aug 29 2017

bhargava.marreddy_broadcom.com added a comment to D12128: bnxt: Use correct firmware ioctl to get number of Rx/Tx queues supported by firmware.

Sean Bruno,

Aug 29 2017, 2:30 PM

Aug 26 2017

bhargava.marreddy_broadcom.com updated the diff for D12128: bnxt: Use correct firmware ioctl to get number of Rx/Tx queues supported by firmware.

Thanks Stephen!! Taken care of your review comments.

Aug 26 2017, 6:02 PM
bhargava.marreddy_broadcom.com added inline comments to D12128: bnxt: Use correct firmware ioctl to get number of Rx/Tx queues supported by firmware.
Aug 26 2017, 5:09 PM
bhargava.marreddy_broadcom.com created D12128: bnxt: Use correct firmware ioctl to get number of Rx/Tx queues supported by firmware.
Aug 26 2017, 11:30 AM

Aug 23 2017

bhargava.marreddy_broadcom.com added a comment to D11914: Bnxt: Add support for displaying Hardware port queue stats using sysctl..

Hi Stephen,

Aug 23 2017, 2:38 PM
bhargava.marreddy_broadcom.com added a reviewer for D11914: Bnxt: Add support for displaying Hardware port queue stats using sysctl.: siva.kallam_broadcom.com.
Aug 23 2017, 12:59 PM
bhargava.marreddy_broadcom.com added a reviewer for D12098: During VLAN creation, bnxt_init() seems to be getting invoked without bnxt_stop().: siva.kallam_broadcom.com.
Aug 23 2017, 12:57 PM