Page MenuHomeFreeBSD
Differential D13023

Bring www/madsonic-standalone to www/libresonic-standalone's standards.
Needs ReviewPublic
Actions

Authored by jlh on Nov 10 2017, 8:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 30, 6:16 PM
Unknown Object (File)
Tue, Apr 30, 6:15 PM
Unknown Object (File)
Tue, Apr 30, 6:15 PM
Unknown Object (File)
Tue, Apr 30, 6:15 PM
Unknown Object (File)
Tue, Apr 30, 6:12 PM
Unknown Object (File)
Tue, Apr 30, 6:12 PM
Unknown Object (File)
Tue, Apr 30, 6:12 PM
Unknown Object (File)
Tue, Apr 30, 2:31 PM
View All 36 Files
Subscribers
brd
tobik

Details

Reviewers
mat
jrm
sbruno
Summary

www/libresonic-standalone was initially made from www/madsonic-standalone.
It was reviewed in https://reviews.freebsd.org/D12597 which led to a lot of
improvements and simplifications. This merges those back to
www/madsonic-standalone.

Test Plan

vimdiff
make clean all install

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12629
Build 12900: arc lint + arc unit

Event Timeline

jlh created this revision.Nov 10 2017, 8:02 AM
Harbormaster completed remote builds in B12614: Diff 35026.Nov 10 2017, 8:02 AM
jlh edited the test plan for this revision. (Show Details)Nov 10 2017, 8:03 AM
jlh updated this revision to Diff 35063.Nov 10 2017, 10:19 PM

Remove a comment which is not valid any more.

Harbormaster completed remote builds in B12629: Diff 35063.Nov 10 2017, 10:19 PM
jlh updated this revision to Diff 35065.Nov 10 2017, 10:27 PM

Fix PORTREVISION (should be 5, not 6).

Harbormaster completed remote builds in B12630: Diff 35065.Nov 10 2017, 10:27 PM
jlh added a reviewer: Ports Committers.Nov 12 2017, 8:47 PM
brd added a subscriber: brd.Nov 20 2017, 2:37 PM

Does it build in poudriere?

jlh added a comment.Nov 21 2017, 9:01 PM

Attached poudriere log.

madsonic-standalone-6.0_6.log23 KBDownload

jlh updated this revision to Diff 35563.Nov 21 2017, 9:04 PM

Sync ports tree.

Harbormaster completed remote builds in B12925: Diff 35563.Nov 21 2017, 9:04 PM
jlh updated this revision to Diff 35565.Nov 21 2017, 9:18 PM

Fix a mismerge.

Harbormaster completed remote builds in B12927: Diff 35565.Nov 21 2017, 9:18 PM
jlh added a comment.Nov 21 2017, 9:21 PM

Added latest poudriere log.

madsonic-standalone-6.0_6.log23 KBDownload

mat requested changes to this revision.Nov 24 2017, 6:04 PM

Don't change from PORTVERSION to DISTVERSION if the version itself does not change.

This revision now requires changes to proceed.Nov 24 2017, 6:04 PM
jlh updated this revision to Diff 35785.Nov 25 2017, 9:49 PM

s/DISTVERSION/PORTVERSION/

Harbormaster completed remote builds in B13063: Diff 35785.Nov 25 2017, 9:49 PM
jrm resigned from this revision.Apr 8 2018, 2:28 AM
mat added inline comments.Apr 11 2018, 8:53 AM
www/madsonic-standalone/Makefile
5–6

Out of order. See Chapter 15. Order of Variables in Port Makefiles.

sbruno resigned from this revision.Jul 14 2018, 4:21 PM
tobik added a subscriber: tobik.Aug 30 2019, 7:27 AM

Is this still relevant? This has been in the Ports Committers review queue for a long time.

www/madsonic-standalone/pkg-plist
6

Double "you" in "If you you"

tobik removed a reviewer: Ports Committers.Dec 5 2019, 4:30 PM

Revision Contents
Changeset List

PathSize
www/
madsonic-standalone/
66 lines
files/
4 lines
44 lines
12 lines

Diff 35063

View Options

www/madsonic-standalone/Makefile

Loading...
View Options

www/madsonic-standalone/files/madsonic.in

Loading...
View Options

www/madsonic-standalone/files/pkg-message.in

Loading...
View Options

www/madsonic-standalone/pkg-plist

Loading...