Don't build share/syscons in build-tools stage if MK_SYSCONS == "no"
ClosedPublic
Actions

Authored by arichardson on Nov 3 2017, 11:30 AM.

Tags

None

Referenced Files

	F103480649: D12926.diff
	Mon, Nov 25, 2:07 PM

	Unknown Object (File)
	Sep 15 2024, 4:29 AM

	Unknown Object (File)
	Sep 13 2024, 11:20 PM

	Unknown Object (File)
	Sep 9 2024, 3:20 AM

	Unknown Object (File)
	Sep 8 2024, 5:34 AM

	Unknown Object (File)
	Sep 8 2024, 2:34 AM

	Unknown Object (File)
	Aug 28 2024, 8:36 PM

	Unknown Object (File)
	Aug 18 2024, 3:57 AM

View All 19 Files

Subscribers

imp

Details

Reviewers

emaste
jhb
brooks
bdrewery

Commits

rS328063: Don't build share/syscons in build-tools stage if MK_SYSCONS == "no"

Test Plan

WITHOUT_SYSCONS no longer builds share/syscons in the build tools stage

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 12418
Build 12694: arc lint + arc unit

Event Timeline

arichardson created this revision.Nov 3 2017, 11:30 AM

Most likely this is correct, just adding Bryan for a sanity check review.

emaste accepted this revision.Dec 19 2017, 2:07 PM

This revision is now accepted and ready to land.Dec 19 2017, 2:07 PM

Ed's confirm is good enough for me.

Closed by commit rS328063: Don't build share/syscons in build-tools stage if MK_SYSCONS == "no" (authored by arichardson). · Explain WhyJan 16 2018, 9:43 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJan 16 2018, 9:43 PM

Revision Contents
Changeset List

Path

Size

Makefile.inc1

2 lines

Diff 34710

View Options

Don't build share/syscons in build-tools stage if MK_SYSCONS == "no"ClosedPublicActions