www/nginx: some style fix; Makefile cleanup

[joneum]

Summary

Do the port clean-up:

-replace '!empty(PORT_OPTIONS:M...)' with '${PORT_OPTIONS:M...}';
-http_accesskey was removed in r439844, cleanup it.

PR: 222337
Reported by: m1cro <[e-mail]>

Approved by: xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

poudriere testport (all options:ON):

10.3-amd64
10.3-i386
10.4-amd64
10.4-i386
11.1-amd64
11.1-i386
12.0-CURRENT r325045 amd64
12.0-CURRENT r325045 i386

[tcberner]

Can't you use

MDSO_CONFIGURE_ON+=[...]
MDSO_CONFIGURE_OFF+=[...]

^ that should obviously be DSO ^^ .. sorry, I see myself to bed.

mfg Tobias

[tcberner]

This comment was removed by tcberner.

[joneum]

In D12915#268253, @tcberner wrote:

Can't you use

MDSO_CONFIGURE_ON+=[...]
MDSO_CONFIGURE_OFF+=[...]

mfg Tobias

www/nginx-devel has been updated with it. That should be the same if nginx on version 1.13. replaced. Therefore, I would like to have it like this. Thank you

[joneum]

Here is the link: https://svnweb.freebsd.org/ports?view=revision&revision=450471

The ports should stay the same. I therefore ask for release. Thank you.

[tcberner]

Please double check the inline comment. If there is nothing there. Go ahead.

www/nginx/Makefile

1206

does this apply to 1.12 too or was this removed by mistake?

[joneum]

www/nginx/Makefile

1206

http_accesskey was removed in r439844