Page MenuHomeFreeBSD

www/nginx: some style fix; Makefile cleanup
ClosedPublic

Authored by joneum on Nov 2 2017, 5:09 PM.

Details

Summary

Do the port clean-up:

-replace '!empty(PORT_OPTIONS:M...)' with '${PORT_OPTIONS:M...}';
-http_accesskey was removed in r439844, cleanup it.

PR: 222337
Reported by: m1cro <rum1cro@yandex.ru>

Approved by: xxx (mentor)
#Differential Revision: https://reviews.freebsd.org/Dxxxxx

Test Plan

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

joneum created this revision.Nov 2 2017, 5:09 PM
tcberner added a comment.EditedNov 2 2017, 9:20 PM

Can't you use

MDSO_CONFIGURE_ON+=[...]
MDSO_CONFIGURE_OFF+=[...]

^ that should obviously be DSO ^^ .. sorry, I see myself to bed.

mfg Tobias

This comment was removed by tcberner.
joneum added a comment.Nov 2 2017, 9:24 PM

Can't you use

MDSO_CONFIGURE_ON+=[...]
MDSO_CONFIGURE_OFF+=[...]

mfg Tobias

www/nginx-devel has been updated with it. That should be the same if nginx on version 1.13. replaced. Therefore, I would like to have it like this. Thank you

joneum added a comment.Nov 2 2017, 9:27 PM

Here is the link: https://svnweb.freebsd.org/ports?view=revision&revision=450471

The ports should stay the same. I therefore ask for release. Thank you.

tcberner accepted this revision.Nov 2 2017, 9:33 PM

Please double check the inline comment. If there is nothing there. Go ahead.

www/nginx/Makefile
1206 ↗(On Diff #34684)

does this apply to 1.12 too or was this removed by mistake?

This revision is now accepted and ready to land.Nov 2 2017, 9:33 PM
joneum added inline comments.Nov 3 2017, 5:53 AM
www/nginx/Makefile
1206 ↗(On Diff #34684)

http_accesskey was removed in r439844

This revision was automatically updated to reflect the committed changes.