Display TRIM/UNMAP support in "diskinfo -v"

[asomers]

Summary

Display TRIM/UNMAP support in "diskinfo -v"

Test Plan

Tested it by hand with a mix of hard drives, comparing against "sg_opcodes" and "camcontrol identify"

[mav]

Generally looks good to me, but I'd probably moved it somewhere before zone mode, and may be also added then GEOM::rotation_rate, GEOM::lunid and GEOM::lunname for completeness.

[allanjude]

I agree with @mav about adding any other useful bits from GEOM that are available.

[imp]

In D12578#260893, @allanjude wrote:

I agree with @mav about adding any other useful bits from GEOM that are available.

Any reason we can't export all the geom attributes? Or do we not have a good way to enumerate them? If not, I totally agree with @mav and @allanjude

[imp]

but even this amount is good, so I'm clicking approve.

[asomers]

There's no way to enumerate all attributes, and some of them (like lunid) aren't available through DIOCGATTR. Plus some, like rotationrate, are complicated to interpret. I'm adding rotationrate right now, but I don't the others (frontstuff, hba_vendor, hba_device, hba_subvendor, hba_subdevice, kerneldump, and setstate) are worthwhile.

[asomers]

Add rotation rate to diskinfo -v

[allanjude]

Thank you

[imp]

usr.sbin/diskinfo/diskinfo.c

303 ↗

(On Diff #33664)

"None" might be better here, though that's a pretty fine hair to split.