PPC: increase MAX_PICS to 32
ClosedPublic
Actions

Authored by wma on Sep 29 2017, 6:41 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Feb 14, 1:11 AM

	Unknown Object (File)
	Wed, Jan 29, 10:20 AM

	Unknown Object (File)
	Dec 5 2024, 7:30 AM

	Unknown Object (File)
	Dec 4 2024, 3:59 PM

	Unknown Object (File)
	Dec 4 2024, 12:19 PM

	Unknown Object (File)
	Nov 29 2024, 3:10 AM

	Unknown Object (File)
	Nov 2 2024, 9:17 AM

	Unknown Object (File)
	Oct 4 2024, 3:37 AM

View All 26 Files

Subscribers

imp

Details

Reviewers

nwhitehorn
jhibbits
adrian
mw

Commits

rS324187: PPC: increase MAX_PICS to 32

Summary

Previous value was too low on dual-socket POWER8 system, 32 seems to be safe for now.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

wma created this revision.Sep 29 2017, 6:41 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 29 2017, 6:41 AM

wma added a reviewer: mw.Sep 29 2017, 7:31 AM

Looks good to me. A better, longer-term, change would be to replace this list entirely with a dynamically allocated linked list or something. It isn't used in early boot (before malloc), or from assembly, or from anywhere performance-critical, so there's really no reason to keep it like this.

This revision is now accepted and ready to land.Sep 29 2017, 2:53 PM

Closed by commit rS324187: PPC: increase MAX_PICS to 32 (authored by wma). · Explain WhyOct 2 2017, 6:05 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

sys/

powerpc/

include/

intr_machdep.h

2 lines

Diff 33550

View Options

sys/powerpc/include/intr_machdep.h

PPC: increase MAX_PICS to 32ClosedPublicActions