PPC: increase MAX_PICS to 32
ClosedPublic
Actions

Authored by wma on Sep 29 2017, 6:41 AM.

Tags

None

Referenced Files

	F168275837: D12540.id.diff
	Thu, Aug 27, 8:24 AM

	Unknown Object (File)
	Tue, Aug 25, 8:53 AM

	Unknown Object (File)
	Tue, Aug 25, 6:53 AM

	Unknown Object (File)
	Wed, Aug 12, 1:08 PM

	Unknown Object (File)
	Wed, Aug 12, 12:53 PM

	Unknown Object (File)
	Wed, Aug 12, 12:35 PM

	Unknown Object (File)
	Tue, Aug 11, 3:49 PM

	Unknown Object (File)
	Mon, Aug 10, 5:56 PM

View All Files

Subscribers

imp

Details

Reviewers

nwhitehorn
jhibbits
adrian
mw

Commits

rS324187: PPC: increase MAX_PICS to 32

Summary

Previous value was too low on dual-socket POWER8 system, 32 seems to be safe for now.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

wma created this revision.Sep 29 2017, 6:41 AM

Herald added a subscriber: imp. · View Herald TranscriptSep 29 2017, 6:41 AM

wma added a reviewer: mw.Sep 29 2017, 7:31 AM

Looks good to me. A better, longer-term, change would be to replace this list entirely with a dynamically allocated linked list or something. It isn't used in early boot (before malloc), or from assembly, or from anywhere performance-critical, so there's really no reason to keep it like this.

This revision is now accepted and ready to land.Sep 29 2017, 2:53 PM

Closed by commit rS324187: PPC: increase MAX_PICS to 32 (authored by wma). · Explain WhyOct 2 2017, 6:05 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

powerpc/

include/

intr_machdep.h

2 lines

Diff 33621

View Options

head/sys/powerpc/include/intr_machdep.h

PPC: increase MAX_PICS to 32ClosedPublicActions