Page MenuHomeFreeBSD

Tag all armv7 kernels as such in their machine config line.
ClosedPublic

Authored by imp on Aug 15 2017, 12:16 AM.

Details

Summary

Transition all boards that support arm cortex CPUs to armv7. This
leaves two armv6 kernels in the tree. RPI-B, which uses the BCM2835
which has a ARM1176 core, and VERSATILEPB, which is a qemu board setup
around the time RPI-B went in. Copy std.armv6 to std.armv7, even
though that duplicates a lot of stuff. More work needs to be done to
sort out the duplication.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

All looks reasonable to me.

I wonder if we should have a comment in std.armv[67] cross-referencing each other with a reminder to keep them in sync as appropriate until broader work to sort out the dplication can happen. Although perhaps in practice folks will be equally likely to miss the comment as to forget to update the other file.

All looks reasonable to me.

I wonder if we should have a comment in std.armv[67] cross-referencing each other with a reminder to keep them in sync as appropriate until broader work to sort out the dplication can happen. Although perhaps in practice folks will be equally likely to miss the comment as to forget to update the other file.

std.arm needs to be involved, and we need to rework things a bit more to cope with old-config files. It too has a lot of duplication. But so does $arch/conf/GENERIC for things that aren't device drivers. It's a lot better than it was a few years ago, but I Agree, we're not done yet. Fortunately, the rate of change is slow enough that I can just keep an eye on things.

Looks good to me.

I don't think we should hold this up to achieve more commonization, that should just proceed separately.

One thing I think would be very useful is a std.arm_debug that's included by arm[v6,v7] and gives re@ a single thing to tweak.

This revision is now accepted and ready to land.Sep 10 2017, 5:59 PM
This revision was automatically updated to reflect the committed changes.