Page MenuHomeFreeBSD
Differential D12003

Use counter(9) for PLPMTUD counters
ClosedPublic
Actions

Authored by kbowling on Aug 12 2017, 5:32 AM.
Tags
Referenced Files
Unknown Object (File)
Sun, Apr 20, 2:26 PM
Unknown Object (File)
Sun, Apr 20, 2:19 PM
Unknown Object (File)
Sun, Apr 20, 1:51 PM
Unknown Object (File)
Sun, Apr 20, 1:46 PM
Unknown Object (File)
Sun, Apr 20, 1:32 PM
Unknown Object (File)
Sun, Apr 20, 1:27 PM
Unknown Object (File)
Sun, Apr 20, 1:16 PM
Unknown Object (File)
Sun, Apr 20, 1:11 PM
View All 90 Files
Subscribers
imp
jtl

Details

Reviewers
sbruno
j-nitrology.com
jtl
Group Reviewers
transport
Commits
rS322900: Use counter(9) for PLPMTUD counters.
Summary

The int increments are not consistent between loads/stores with multiple threads and may lose events during concurrent updates. tcpstats solves that problem with no real downsides.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kbowling created this revision.Aug 12 2017, 5:32 AM
Herald added a reviewer: transport. · View Herald TranscriptAug 12 2017, 5:32 AM
Herald added a subscriber: imp. · View Herald Transcript
kbowling updated this revision to Diff 32032.Aug 14 2017, 6:17 AM
kbowling edited the summary of this revision. (Show Details)
jtl accepted this revision.Aug 14 2017, 1:08 PM
jtl added a subscriber: jtl.

Looks good (with one minor nit inline).

usr.bin/netstat/inet.c
760 ↗(On Diff #32032)

Minor (yes, very minor) nit: On these three lines, the plural should probably be conditioned on the number. %s does this for you automatically.

So, for example "...detection activation%s}\n".

This revision is now accepted and ready to land.Aug 14 2017, 1:08 PM
kbowling updated this revision to Diff 32059.Aug 14 2017, 6:54 PM
kbowling edited edge metadata.

Use the libxo plurals and fix the pmtud-failed label

This revision now requires review to proceed.Aug 14 2017, 6:54 PM
kbowling added a comment.Aug 14 2017, 8:45 PM

Noob question, should freebsdversion bump since this alters the ABI?

Closed by commit rS322900: Use counter(9) for PLPMTUD counters. (authored by sbruno). · Explain WhyAug 25 2017, 7:42 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
5 lines
sys/
netinet/
33 lines
5 lines
sys/
2 lines
usr.bin/
netstat/
14 lines

Diff 32396

View Options

head/UPDATING

Loading...
View Options

head/sys/netinet/tcp_timer.c

Loading...
View Options

head/sys/netinet/tcp_var.h

Loading...
View Options

head/sys/sys/param.h

Loading...
View Options

head/usr.bin/netstat/inet.c

Loading...