Ensure .CURDIR contains the absolute pathname without a trailing slash, otherwise a port may fail to build

[jrm]

Summary

Example breakage:
make -C /usr/ports/audio/teamspeak3-server/

I think using ${.CURDIR:tA} is preferred to ${.CURDIR:C/\/$//}, because similiar
problems can occur when the argument to -C contains symbolic links.

See https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=221296

[jrm]

Improve comment

[bdrewery]

This may cause problems for symlinked ${PORTSDIR} checkouts (I am merely guessing and haven't thought about it heavily).

I think this is the wrong fix... Either bmake should be doing this itself or whatever is *failing* due to the trailing _/_ needs to be fixed.

[jrm]

In D11934#247765, @bdrewery wrote:

This may cause problems for symlinked ${PORTSDIR} checkouts (I am merely guessing and haven't thought about it heavily).

I think this is the wrong fix... Either bmake should be doing this itself or whatever is *failing* due to the trailing _/_ needs to be fixed.

It certainly would be cleaner if bmake did the right thing (call GETCWD(3) on .CURDIR ?). Note that the problem isn't just with trailing /'s; see the PR linked to in the description. "[W]hatever is *failing* [...] _/_ needs to be fixed" may still apply.

[sjg]

The change to leaving -C arg "as is" is fairly recent, I've fixed a few bugs caused by it...

​.CURDIR:= ${.CURDIR:tA}
​
should be reasonably harmless, if and is essentially what bmake used to do.