Page MenuHomeFreeBSD

Fix a comment post-r320347
ClosedPublic

Authored by jhibbits on Jun 26 2017, 3:02 AM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 9, 6:51 PM
Unknown Object (File)
Mon, Mar 9, 10:50 AM
Unknown Object (File)
Mon, Mar 9, 4:52 AM
Unknown Object (File)
Sun, Mar 8, 10:47 PM
Unknown Object (File)
Sat, Mar 7, 3:16 PM
Unknown Object (File)
Tue, Feb 24, 7:09 AM
Unknown Object (File)
Sun, Feb 22, 3:50 AM
Unknown Object (File)
Tue, Feb 17, 10:19 AM
Subscribers

Details

Summary

As of r320347 i386 is the only arch with 32-bit time_t. Instead of
just fixing the time32_t comment, also simplify the condition.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kib added inline comments.
sys/compat/freebsd32/freebsd32.h
48 ↗(On Diff #30078)
#ifdef __amd64__
typedef int32_t time32_t;
#else
...
This revision is now accepted and ready to land.Jun 26 2017, 11:39 AM

Perhaps apply the same treatment to sys/compat/freebsd32/freebsd32_misc.c? (and sys/net/bpf.c)?

jhibbits edited edge metadata.

Add more files that only need amd64 guards.

This revision now requires review to proceed.Jun 26 2017, 2:49 PM
This revision is now accepted and ready to land.Jun 26 2017, 3:29 PM

I was going to suggest the same change.

This revision was automatically updated to reflect the committed changes.