Rearrange the download into more readable tables
Improve the text and descriptions around the tables
Details
Diff Detail
- Repository
- rD FreeBSD doc repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Overall, I like the idea, but the issues noted inline need to be addressed.
en_US.ISO8859-1/htdocs/where.xml | ||
---|---|---|
6 ↗ | (On Diff #2261) | No, please do not change these from 'ftp://' to 'http://'. Not all FreeBSD.org mirrors are http-capable. |
29 ↗ | (On Diff #2261) | The content changes in this paragraph are not correct. Please revert this paragraph. |
38 ↗ | (On Diff #2261) | I would avoid hard-coding another date, and just word it as "modern PCs". |
en_US.ISO8859-1/share/xml/release.l10n.ent | ||
88 ↗ | (On Diff #2261) | Please do not move the entire contents of en_US.ISO8859-1/share/xml/release.l10n.ent into en_US.ISO8859-1/htdocs/where.xml. The separation of the two is intentional, and moving the contents in their entirety to where.xml will add complexity for translated versions that have not yet caught up with the en_US version. |
Only one nit from me. I think gjb@ should have the final say about whether he likes the new layout or not as he (or re@ in general) is the one who is maintaining that page when a new release comes out.
en_US.ISO8859-1/htdocs/where.xml | ||
---|---|---|
25 ↗ | (On Diff #2279) | I think we also have &amd; or even &amd64; trademarks as entities. |
Clean up header sizing
Move linebreaks to after tables where they should be
Remove the empty 'Release Information' header, the link is elsewhere on the page
Allan showed me a rendered version of this page at http://allanjude.com/bsd/where/where.html
This is far better than what was there before.
Thanks for working on this.
I am on re@ also, so you can consider this an additional re@ viewpoint to gjb.
I like this. The only quibble I have is that the meaning of "Machine Images" is not immediately obvious, and I would suggest "Virtual Machine Images" instead.
I agree with wblock@ that the "machine images" section is a misnomer.
In addition, the armv6 images should not be included within the "machine images" section.
They should be their own category, but I do not think that deems their own column necessary. I would put them in the same column as ISOs, since the underlying system that is run is something that is written to a disk (CD-ROM, DVD, SD card, etc.), whereas the virtual machine disk images are attached to a hypervisor.
en_US.ISO8859-1/share/xml/release.l10n.ent | ||
---|---|---|
88 ↗ | (On Diff #2261) | Ignore this comment, I misread the diff. |
Sigh..
I have no idea how to tell this kindergarden review software that my reply had nothing to do with the inline comment that it referenced...
So, for clarify, my last comment had nothing to do with comment 88, which was referenced in the email generated.
So, for clarify, my last comment had nothing to do with comment 88, which was referenced in the email generated.
Everything was clear to me without the followup: I see two comments, one global in response to @wblock and one a followup on line 88.
Updated with feedback from wblock and gjb
I also updated the rendered version for previewing:
http://allanjude.com/bsd/where/where.html
en_US.ISO8859-1/htdocs/where.xml | ||
---|---|---|
79 ↗ | (On Diff #2997) | I don't think it's a good idea to have the EoL dates on multiple pages. It's difficult enough keeping things in sync between the releng/ and security/ pages as it is now. Adding it here too only increases the propensity for making mistakes. |
en_US.ISO8859-1/share/xml/release.l10n.ent | ||
95 ↗ | (On Diff #2997) | Any reason, in particular, for this? |
en_US.ISO8859-1/htdocs/where.xml | ||
---|---|---|
79 ↗ | (On Diff #2997) | Yeah, when I added this originally, I thought there was an entity for it. I'll remove it |
25 ↗ | (On Diff #2279) | Neither of those entities work in where.xml. Not all of the entities are hooked up to the web build, you can't use &url.books.porters-handbook; etc either. |
en_US.ISO8859-1/share/xml/release.l10n.ent | ||
95 ↗ | (On Diff #2997) | It separates this table from the next heading (the -current snapshots) when this segment gets included |
en_US.ISO8859-1/htdocs/where.xml | ||
---|---|---|
25 ↗ | (On Diff #2279) | The where.xml page does not include the docbook entity pages. It is separate from the Handbook (or other 'doc' (i.e., not 'web')) pages. In other words, the htdocs/ stuff and other things within the top-level $LANG directory are mutually exclusive. This is not something we intend to change. |
en_US.ISO8859-1/share/xml/release.l10n.ent | ||
95 ↗ | (On Diff #2997) | Got it. Thanks. |
I have not build-tested the latest proposed changes, but the lastest renditions resolve my previous concerns.
I might bother you about some text changes later, but this builds okay here and is a big improvement.