Page MenuHomeFreeBSD

Document st_flags in the stat(2).
ClosedPublic

Authored by sobomax on May 22 2017, 5:02 AM.
Tags
None
Referenced Files
F103263766: D10852.id29721.diff
Fri, Nov 22, 7:31 PM
Unknown Object (File)
Tue, Nov 19, 7:21 PM
Unknown Object (File)
Tue, Nov 19, 11:47 AM
Unknown Object (File)
Oct 18 2024, 8:01 AM
Unknown Object (File)
Oct 17 2024, 7:52 AM
Unknown Object (File)
Oct 16 2024, 4:04 PM
Unknown Object (File)
Oct 13 2024, 12:56 PM
Unknown Object (File)
Oct 9 2024, 7:22 PM

Details

Summary

The st_flags is quite important bit of info returned by the stat and used a lot around the code, yet not mentioned in the man page. Fill in the void by xref-ing chflags manpage.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 9429

Event Timeline

vangyzen added a subscriber: vangyzen.
vangyzen added inline comments.
lib/libc/sys/stat.2
31

Remember to bump this when you commit.

141

"User-defined" should be hyphenated.

Add "the" before "file".

This revision is now accepted and ready to land.May 22 2017, 12:34 PM
jilles added inline comments.
lib/libc/sys/stat.2
141

I think "user-defined" should be removed entirely, since file flags are no more user-defined than permission bits are.

lib/libc/sys/stat.2
141

Good point. Agreed.

Maybe the original author meant "user-assigned", but even that seems too verbose.

mckusick added inline comments.
lib/libc/sys/stat.2
141

I concur with jilles. I would word it as "The file's flags." or perhaps "The flags enabled for the file.''

This revision now requires changes to proceed.May 22 2017, 9:48 PM

With suggested change, I am happy with this (useful) update.

This revision is now accepted and ready to land.May 22 2017, 10:05 PM
sobomax edited edge metadata.

Re-phrase a bit based on suggestions.

This revision now requires review to proceed.May 23 2017, 1:47 AM

Adjusted a bit as suggested.

This revision is now accepted and ready to land.May 23 2017, 12:52 PM

Looks good. Make it so.

This revision was automatically updated to reflect the committed changes.