Details
Details
- Reviewers
zbb loos mmel - Commits
- rS318409: Fix registration of MPIC driver
Diff Detail
Diff Detail
- Repository
- rS FreeBSD src repository - subversion
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
I think you can simplify this fix if you move the OF_device_register_xref() to happen before the if(). This way the if() don't need to be changed:
Index: arm/mv/mpic.c =================================================================== --- arm/mv/mpic.c (revision 318000) +++ arm/mv/mpic.c (working copy) @@ -273,6 +273,7 @@ bus_release_resources(dev, mv_mpic_spec, sc->mpic_res); return (ENXIO); } + OF_device_register_xref(OF_xref_from_node(ofw_bus_get_node(dev)), dev); if (intr_pic_register(dev, OF_xref_from_device(dev)) == NULL) { device_printf(dev, "could not register PIC\n"); bus_release_resources(dev, mv_mpic_spec, sc->mpic_res);