sys/dev/xdma/controller/pl330.c
91–92	You could make these a single `struct resource *`, then use `bus_read_4` and `bus_write_4`.
130	I think we might need to think about a new `bus_alloc_resources` like function to handle this sort of thing.
181	Why `0x10000`?
197–199	I wonder if there should be macros for these, e.g. #define MOV_3(val) (((val) >> 8) & 0xff) ... buf[3] = MOV_3(val)
496	What will happen when `len` is not a multiple of 4?
498	What is the meaning of `0` here, and `1` below?
512–514	Could these be merged into a single call?
548–550	Is this needed?
553	Magic `0x10000` again
636	We should probably add a DMA bus pass.
sys/dev/xdma/controller/pl330.h
32	It might pay to add a guard against including this header twice.
43	You should put `n` in parentheses, i.e. `#define FTR(n) (0x040 + 0x04 * (n))`
76	Why `#if 0` and not `/* ... */`?
108–111	I would put these in the `.c` file, they don't seem to be needed anywhere else.

dehardcode src/dst port width

br marked an inline comment as done.Apr 3 2017, 2:01 PM

br added inline comments.

sys/dev/xdma/controller/pl330.c
496	ok I dehardcoded port width. port width is now specified by application. Thanks!
498	offs0 is the jump address for loop0, while offs1 is the jump addr for loop1
512–514	Yes. I merged this to single call
548–550	No. Thanks
636	agree