User Details
- User Since
- Jul 26 2015, 3:06 PM (499 w, 3 d)
Dec 13 2020
Jul 30 2020
Jun 23 2020
Whitespace nits
Jun 17 2020
+1 for relaxing style(9) to match what available tooling can support.
Jun 9 2020
I just find the mixed-case thing personally amusing, nothing else. As long as it's consistent, I'm fine with it. Let's ship this!
Jun 3 2020
@cem Thanks! Updated.
Dec 13 2019
Aug 15 2019
Jul 12 2019
Jul 11 2019
Jul 6 2019
@marc.priggemeyer_gmail.com or @markj, is what's here sufficient for now, or do the edev fixes need to go in, too? It looked like suspend/resume was the biggest issue. I'm worried about this review being a casualty of perfection vs making incremental, usable progress. Given the successes reported so far, I'm trying to gauge what's mandatory vs what should be done next post-commit.
Jul 3 2019
Jun 28 2019
Jun 25 2019
Looks good, but potentially a suggestion.
May 28 2019
Integrity of the base distfiles is left to the administrator. Maintaining the chain of trust is outside of the scope of building base packages, whereas pkg for ports packages and distfiles does require pkg to maintain a chain of trust. Source code acquisition via ssh, https, or fetching tarballs and comparing the SHAs all seem like prerequisites for building a package base system, therefore out of scope for the proposed set of patches here. Said differently, if a release engineer can't ensure integrity of the source used to build a jail, the release engineer has bigger problems.
May 24 2019
May 16 2019
Apr 29 2019
Apr 27 2019
Terse explanation of what this actually means.
Benchmarks that aren't horribly flawed are candidates for publication (e.g. thinks that aren't compiled with -O0 or other invasive debugging flags that create unfair comparisons).
Update the title page to be more succinct.
Trim the second event that was accidentally copy/pasted.