User Details
User Details
- User Since
- Jun 2 2025, 7:29 PM (19 w, 17 h)
Sep 7 2025
Sep 7 2025
Aug 27 2025
Aug 27 2025
saheed updated the diff for D52128: libifconfig: Add netlink based helper to bring the interface up/down.
Change ifconfig_if_up/down() to ifconfig_set_up()
saheed added a comment to D52128: libifconfig: Add netlink based helper to bring the interface up/down.
Respond to review comments
Aug 23 2025
Aug 23 2025
This revision shall be closed in favor of D52056 :)
saheed updated the diff for D51871: netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler.
Removed handling IFF_PROMISC when ifi_change=0
I'll reopen this revision to have only IFF_UP related change without touching IFF_PROMISC
I tested it out, it works nicely :)
Aug 22 2025
Aug 22 2025
This revision has been split among:
saheed requested review of D52131: libifconfig: Add netlink based IPv4/v6 address helper functions.
saheed requested review of D52130: libifconfig: Add netlink based helpers to retrieve and set MAC address.
saheed requested review of D52128: libifconfig: Add netlink based helper to bring the interface up/down.
saheed planned changes to D52027: libifconfig: Add netlink based link and address helper functions.
Since the changes are quite large, I'll split them into smaller revisions :)
saheed updated the diff for D51922: netlink/route: Support modifying IFLA_ADDRESS with RTM_NEWLINK.
Include if_setlladdr error code in err_msg
saheed added a comment to D52126: netlink/route: Support modifying IFLA_ADDRESS with RTM_NEWLINK.
this revision was opened by mistake :')
saheed requested review of D52126: netlink/route: Support modifying IFLA_ADDRESS with RTM_NEWLINK.
Aug 21 2025
Aug 21 2025
saheed added inline comments to D52056: netlink: Bypass refcounting when setting promiscuity.
Aug 20 2025
Aug 20 2025
saheed requested review of D52047: ifpromisc: Ignore "off" requests when refcount is zero.
Aug 19 2025
Aug 19 2025
saheed updated the summary of D52027: libifconfig: Add netlink based link and address helper functions.
saheed requested review of D52027: libifconfig: Add netlink based link and address helper functions.
Aug 15 2025
Aug 15 2025
saheed added reviewers for D51922: netlink/route: Support modifying IFLA_ADDRESS with RTM_NEWLINK: getz, obiwac.
saheed requested review of D51922: netlink/route: Support modifying IFLA_ADDRESS with RTM_NEWLINK.
Aug 14 2025
Aug 14 2025
saheed updated the summary of D51871: netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler.
saheed updated the diff for D51871: netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler.
- netlink: Modify all flags when ifi_change is 0 in RTM_NEWLINK
Aug 12 2025
Aug 12 2025
saheed added a comment to D51871: netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler.
I too think we should have this bug compatibility
saheed added a reviewer for D51871: netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler: kp.
saheed added a comment to D51871: netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler.
This fix has existed out of tree in @obiwac's BATMAN
tree
:)
saheed requested review of D51871: netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler.
Jun 3 2025
Jun 3 2025
saheed updated the diff for D50666: libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp.
Append "Sponsored by: Google LLC (GSoC)" to commits