Page MenuHomeFreeBSD

saheed (Muhammad Saheed)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 2 2025, 7:29 PM (19 w, 17 h)

Recent Activity

Sep 7 2025

saheed accepted D52415: Summary: Remove support for FreeBSD end-of-life 14.2 (2025-09-30).

lgtm

Sep 7 2025, 9:11 PM

Aug 27 2025

saheed updated the diff for D52128: libifconfig: Add netlink based helper to bring the interface up/down.

Change ifconfig_if_up/down() to ifconfig_set_up()

Aug 27 2025, 8:19 AM
saheed added a comment to D52128: libifconfig: Add netlink based helper to bring the interface up/down.

Respond to review comments

Aug 27 2025, 6:12 AM

Aug 23 2025

saheed abandoned D52047: ifpromisc: Ignore "off" requests when refcount is zero.

This revision shall be closed in favor of D52056 :)

Aug 23 2025, 2:49 PM
saheed updated the diff for D51871: netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler.

Removed handling IFF_PROMISC when ifi_change=0

Aug 23 2025, 2:37 PM
saheed reopened D51871: netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler.

I'll reopen this revision to have only IFF_UP related change without touching IFF_PROMISC

Aug 23 2025, 2:28 PM
saheed accepted D52132: netlink: Handle `ifhwioctl(SIOCSIFMTU)` failure.
Aug 23 2025, 1:34 PM
saheed accepted D52056: netlink: Bypass refcounting when setting promiscuity.

I tested it out, it works nicely :)

Aug 23 2025, 1:33 PM

Aug 22 2025

saheed abandoned D52027: libifconfig: Add netlink based link and address helper functions.

This revision has been split among:

Aug 22 2025, 8:15 PM
saheed requested review of D52131: libifconfig: Add netlink based IPv4/v6 address helper functions.
Aug 22 2025, 8:07 PM
saheed requested review of D52130: libifconfig: Add netlink based helpers to retrieve and set MAC address.
Aug 22 2025, 7:57 PM
saheed requested review of D52128: libifconfig: Add netlink based helper to bring the interface up/down.
Aug 22 2025, 6:18 PM
saheed planned changes to D52027: libifconfig: Add netlink based link and address helper functions.

Since the changes are quite large, I'll split them into smaller revisions :)

Aug 22 2025, 5:52 PM
saheed updated the diff for D51922: netlink/route: Support modifying IFLA_ADDRESS with RTM_NEWLINK.

Include if_setlladdr error code in err_msg

Aug 22 2025, 5:40 PM
saheed added a comment to D52126: netlink/route: Support modifying IFLA_ADDRESS with RTM_NEWLINK.

this revision was opened by mistake :')

Aug 22 2025, 4:58 PM
saheed abandoned D52126: netlink/route: Support modifying IFLA_ADDRESS with RTM_NEWLINK.
Aug 22 2025, 4:57 PM
saheed requested review of D52126: netlink/route: Support modifying IFLA_ADDRESS with RTM_NEWLINK.
Aug 22 2025, 4:52 PM

Aug 21 2025

saheed added inline comments to D52056: netlink: Bypass refcounting when setting promiscuity.
Aug 21 2025, 10:48 PM

Aug 20 2025

saheed requested review of D52047: ifpromisc: Ignore "off" requests when refcount is zero.
Aug 20 2025, 1:16 PM

Aug 19 2025

saheed updated the summary of D52027: libifconfig: Add netlink based link and address helper functions.
Aug 19 2025, 4:27 PM
saheed requested review of D52027: libifconfig: Add netlink based link and address helper functions.
Aug 19 2025, 4:26 PM

Aug 15 2025

saheed added reviewers for D51922: netlink/route: Support modifying IFLA_ADDRESS with RTM_NEWLINK: getz, obiwac.
Aug 15 2025, 7:16 PM
saheed requested review of D51922: netlink/route: Support modifying IFLA_ADDRESS with RTM_NEWLINK.
Aug 15 2025, 7:14 PM

Aug 14 2025

saheed updated the summary of D51871: netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler.
Aug 14 2025, 8:57 AM
saheed updated the diff for D51871: netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler.
  • netlink: Modify all flags when ifi_change is 0 in RTM_NEWLINK
Aug 14 2025, 7:21 AM

Aug 12 2025

saheed added a comment to D51871: netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler.
In D51871#1185539, @kp wrote:

I'd be inclined to pick up Linux's bug compatibility as well. Presumably there's code out there that makes this incorrect assumption about ifi_change, and we may as well go all out on being compatible. Especially if it's easy to do. That can be done separately if you prefer (or not at all, if either of you have strong views here).

I too think we should have this bug compatibility

Aug 12 2025, 4:14 PM
saheed added a reviewer for D51871: netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler: kp.
Aug 12 2025, 9:10 AM
saheed added a comment to D51871: netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler.

This fix has existed out of tree in @obiwac's BATMAN tree
:)

Aug 12 2025, 9:03 AM
saheed requested review of D51871: netlink: Fix IFF_UP flag handling in RTM_NEWLINK's modify_link handler.
Aug 12 2025, 8:15 AM

Jun 3 2025

saheed updated the diff for D50666: libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp.

Append "Sponsored by: Google LLC (GSoC)" to commits

Jun 3 2025, 4:25 PM
saheed requested review of D50666: libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp.
Jun 3 2025, 1:37 PM