Page MenuHomeFreeBSD
Differential D51922

netlink/route: Support modifying IFLA_ADDRESS with RTM_NEWLINK
ClosedPublic
Actions

Authored by saheed on Aug 15 2025, 7:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 30, 6:31 AM
Unknown Object (File)
Tue, Sep 29, 8:44 PM
Unknown Object (File)
Tue, Sep 29, 4:01 PM
Unknown Object (File)
Tue, Sep 29, 5:49 AM
Unknown Object (File)
Sat, Sep 26, 12:05 PM
Unknown Object (File)
Thu, Sep 24, 3:40 AM
Unknown Object (File)
Thu, Sep 24, 3:08 AM
Unknown Object (File)
Thu, Sep 17, 6:51 AM
View All Files
Subscribers
glebius
imp
mckusick
melifaro

Details

Reviewers
melifaro
getz
obiwac
mckusick
Commits
rGf13a042a5711: netlink/route: Support modifying IFLA_ADDRESS with RTM_NEWLINK
Summary

Allows setting link-layer address (MAC) by specifying the IFLA_ADDRESS
attribute on RTM_NEWLINK requests.

Sponsored by: Google LLC (GSoC)

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

saheed created this revision.Aug 15 2025, 7:14 PM
Herald added a reviewer: melifaro. · View Herald TranscriptAug 15 2025, 7:14 PM
Herald added subscribers: glebius, melifaro, imp. · View Herald Transcript
saheed requested review of this revision.Aug 15 2025, 7:14 PM
Harbormaster completed remote builds in B66271: Diff 160407.Aug 15 2025, 7:14 PM
saheed added reviewers: getz, obiwac.Aug 15 2025, 7:16 PM
obiwac accepted this revision.Aug 17 2025, 12:11 AM

looks perfect :)

sys/netlink/route/iface_drivers.c
114–115

if_setlladdr can return multiple error codes, could be useful to include this in the error message

This revision is now accepted and ready to land.Aug 17 2025, 12:11 AM
saheed mentioned this in D52027: libifconfig: Add netlink based link and address helper functions.Aug 19 2025, 4:26 PM
saheed added a child revision: D52027: libifconfig: Add netlink based link and address helper functions.
saheed updated this revision to Diff 160832.Aug 22 2025, 5:40 PM

Include if_setlladdr error code in err_msg

This revision now requires review to proceed.Aug 22 2025, 5:40 PM
Harbormaster completed remote builds in B66462: Diff 160832.Aug 22 2025, 5:40 PM
saheed marked an inline comment as done.Aug 22 2025, 5:40 PM
saheed mentioned this in D52130: libifconfig: Add netlink based helpers to retrieve and set MAC address.Aug 22 2025, 7:57 PM
saheed added a child revision: D52130: libifconfig: Add netlink based helpers to retrieve and set MAC address.Aug 22 2025, 8:17 PM
melifaro accepted this revision.Aug 23 2025, 11:55 AM
This revision is now accepted and ready to land.Aug 23 2025, 11:55 AM
mckusick accepted this revision.Aug 23 2025, 6:25 PM
mckusick added a subscriber: mckusick.

Mentor approval.

Closed by commit rGf13a042a5711: netlink/route: Support modifying IFLA_ADDRESS with RTM_NEWLINK (authored by saheed, committed by obiwac). · Explain WhyAug 23 2025, 7:14 PM
This revision was automatically updated to reflect the committed changes.
obiwac added a commit: rGf13a042a5711: netlink/route: Support modifying IFLA_ADDRESS with RTM_NEWLINK.

Revision Contents
Changeset List

PathSize
sys/
netlink/
route/
1 line
18 lines
1 line

Diff 160886

View Options

sys/netlink/route/iface.c

Loading...
View Options

sys/netlink/route/iface_drivers.c

Loading...
View Options

sys/netlink/route/route_var.h

Loading...