Page MenuHomeFreeBSD

libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp
ClosedPublic

Authored by saheed on Jun 3 2025, 1:37 PM.
Tags
None
Referenced Files
F151226574: D50666.id160633.diff
Mon, Apr 6, 11:47 PM
Unknown Object (File)
Sun, Apr 5, 5:34 AM
Unknown Object (File)
Sat, Apr 4, 7:16 PM
Unknown Object (File)
Sat, Apr 4, 2:13 PM
Unknown Object (File)
Wed, Apr 1, 5:47 AM
Unknown Object (File)
Mon, Mar 30, 6:14 PM
Unknown Object (File)
Mon, Mar 30, 3:20 AM
Unknown Object (File)
Sun, Mar 29, 11:45 PM
Subscribers

Details

Summary

Removed the declaration of ifconfig_set_fib from libifconfig.h as it had no
definition.

ifconfig_sfp_id_is_qsfp is defined as a static header function in
libifconfig_sfp.h and doesn't generate a symbol.

Both have been removed from Symbol.map

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

saheed requested review of this revision.Jun 3 2025, 1:37 PM

Append "Sponsored by: Google LLC (GSoC)" to commits

lib/libifconfig/Symbol.map
84

this is used by ifconfig (sbin/ifconfig/sfp.c) right?

obiwac added inline comments.
lib/libifconfig/Symbol.map
84

ah no its defined statically in the header, you wrote that in your description already, sorry

This revision is now accepted and ready to land.Aug 19 2025, 10:56 PM
mckusick added a subscriber: mckusick.

Mentor approval for commit.