Page MenuHomeFreeBSD

libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp
ClosedPublic

Authored by saheed on Jun 3 2025, 1:37 PM.
Tags
None
Referenced Files
F135979235: D50666.id160633.diff
Fri, Nov 14, 6:47 PM
Unknown Object (File)
Fri, Nov 14, 11:44 AM
Unknown Object (File)
Wed, Nov 5, 3:06 AM
Unknown Object (File)
Tue, Oct 28, 9:00 PM
Unknown Object (File)
Mon, Oct 27, 5:39 PM
Unknown Object (File)
Sat, Oct 25, 6:28 PM
Unknown Object (File)
Oct 12 2025, 4:37 PM
Unknown Object (File)
Oct 12 2025, 4:50 AM
Subscribers

Details

Summary

Removed the declaration of ifconfig_set_fib from libifconfig.h as it had no
definition.

ifconfig_sfp_id_is_qsfp is defined as a static header function in
libifconfig_sfp.h and doesn't generate a symbol.

Both have been removed from Symbol.map

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

saheed requested review of this revision.Jun 3 2025, 1:37 PM

Append "Sponsored by: Google LLC (GSoC)" to commits

lib/libifconfig/Symbol.map
84

this is used by ifconfig (sbin/ifconfig/sfp.c) right?

obiwac added inline comments.
lib/libifconfig/Symbol.map
84

ah no its defined statically in the header, you wrote that in your description already, sorry

This revision is now accepted and ready to land.Aug 19 2025, 10:56 PM
mckusick added a subscriber: mckusick.

Mentor approval for commit.