Page MenuHomeFreeBSD

libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp
ClosedPublic

Authored by saheed on Jun 3 2025, 1:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Oct 12, 4:37 PM
Unknown Object (File)
Sun, Oct 12, 4:50 AM
Unknown Object (File)
Sun, Oct 12, 12:56 AM
Unknown Object (File)
Thu, Oct 9, 5:37 PM
Unknown Object (File)
Mon, Oct 6, 1:27 AM
Unknown Object (File)
Fri, Oct 3, 1:36 PM
Unknown Object (File)
Fri, Oct 3, 12:12 AM
Unknown Object (File)
Thu, Oct 2, 1:59 PM
Subscribers

Details

Summary

Removed the declaration of ifconfig_set_fib from libifconfig.h as it had no
definition.

ifconfig_sfp_id_is_qsfp is defined as a static header function in
libifconfig_sfp.h and doesn't generate a symbol.

Both have been removed from Symbol.map

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

saheed requested review of this revision.Jun 3 2025, 1:37 PM

Append "Sponsored by: Google LLC (GSoC)" to commits

lib/libifconfig/Symbol.map
84

this is used by ifconfig (sbin/ifconfig/sfp.c) right?

obiwac added inline comments.
lib/libifconfig/Symbol.map
84

ah no its defined statically in the header, you wrote that in your description already, sorry

This revision is now accepted and ready to land.Aug 19 2025, 10:56 PM
mckusick added a subscriber: mckusick.

Mentor approval for commit.