Page MenuHomeFreeBSD
Differential D50666

libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp
ClosedPublic
Actions

Authored by saheed on Jun 3 2025, 1:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Apr 27, 5:58 PM
Unknown Object (File)
Fri, Apr 24, 6:46 AM
Unknown Object (File)
Thu, Apr 23, 7:02 AM
Unknown Object (File)
Tue, Apr 21, 7:10 PM
Unknown Object (File)
Sun, Apr 19, 8:38 PM
Unknown Object (File)
Sun, Apr 19, 8:38 PM
Unknown Object (File)
Sun, Apr 19, 1:34 PM
Unknown Object (File)
Sun, Apr 19, 1:33 PM
View All 97 Files
Subscribers
imp
mckusick

Details

Reviewers
getz
obiwac
mckusick
Commits
rG75acf71786f2: libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp
Summary

Removed the declaration of ifconfig_set_fib from libifconfig.h as it had no
definition.

ifconfig_sfp_id_is_qsfp is defined as a static header function in
libifconfig_sfp.h and doesn't generate a symbol.

Both have been removed from Symbol.map

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 64617
Build 61501: arc lint + arc unit

Event Timeline

saheed created this revision.Jun 3 2025, 1:37 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 3 2025, 1:37 PM
saheed requested review of this revision.Jun 3 2025, 1:37 PM
Harbormaster completed remote builds in B64615: Diff 156473.Jun 3 2025, 1:37 PM
saheed updated this revision to Diff 156477.Jun 3 2025, 4:25 PM

Append "Sponsored by: Google LLC (GSoC)" to commits

Harbormaster completed remote builds in B64617: Diff 156477.Jun 3 2025, 4:25 PM
obiwac added inline comments.Aug 19 2025, 10:55 PM
lib/libifconfig/Symbol.map
84

this is used by ifconfig (sbin/ifconfig/sfp.c) right?

obiwac accepted this revision.Aug 19 2025, 10:56 PM
obiwac added inline comments.
lib/libifconfig/Symbol.map
84

ah no its defined statically in the header, you wrote that in your description already, sorry

This revision is now accepted and ready to land.Aug 19 2025, 10:56 PM
mckusick accepted this revision.Aug 19 2025, 11:00 PM
mckusick added a subscriber: mckusick.

Mentor approval for commit.

Closed by commit rG75acf71786f2: libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp (authored by saheed, committed by obiwac). · Explain WhyAug 19 2025, 11:09 PM
This revision was automatically updated to reflect the committed changes.
obiwac added a commit: rG75acf71786f2: libifconfig: Remove ifconfig_set_fib and ifconfig_sfp_id_is_qsfp.

Revision Contents
Changeset List

PathSize
lib/
libifconfig/
2 lines
1 line

Diff 156477

View Options

lib/libifconfig/Symbol.map

Loading...
View Options

lib/libifconfig/libifconfig.h

Loading...