Page MenuHomeFreeBSD

pitwuu_gmail.com (Philippe Michaud-Boudreault)
philmb

Projects

User does not belong to any projects.

User Details

User Since
May 12 2021, 4:12 PM (18 w, 2 d)

Recent Activity

Jun 14 2021

pitwuu_gmail.com added a comment to D30332: linuxulator: Add FUTEX_REQUEUE for musl libc. .

Im don't understand what do you mean, I mean that musl it's a separate brand, see Elf_Brandinfo and linux_sysvec.c,
and only for musl brand we should change cmp_requeue, for glibc brand cmp_requeue should return EINVAL

Jun 14 2021, 4:53 AM · Linux Emulation
pitwuu_gmail.com added a comment to D30457: linuxulator: Some ptrace fixes...

Nice! Regarding GET_SYSCALL_INFO - this reminded me that I also had a patch for this, https://reviews.freebsd.org/D28212; I guess we should try merging our changes.

There's some activity right now regarding Linuxulator signal delivery, https://reviews.freebsd.org/D30675; I wonder if it's related?

Jun 14 2021, 4:42 AM

Jun 1 2021

pitwuu_gmail.com added a comment to D30597: linux: implement splice(2).

Does this have test coverage via e.g. LTP?

yes, also linux source at tools/testing/selftests/splice

Jun 1 2021, 6:29 PM
pitwuu_gmail.com added a comment to D30597: linux: implement splice(2).

Cool. Thanks for working on it. Obviously this is an "emulation" way of implementing splice(2) and not the real thing, but I like this. Do you happen to know which software requires the splice(2) call for its correct operation?

Jun 1 2021, 4:00 PM
pitwuu_gmail.com added a comment to D30457: linuxulator: Some ptrace fixes...

This looks really interesting, thanks for working on it!

Which version of strace(1) are you testing with? I kind of hoped this would fix the one from Ubuntu Focal (the one from Bionic already worked fine), but this doesn't seem to be the case.

Jun 1 2021, 3:12 PM

May 30 2021

pitwuu_gmail.com added a comment to D30543: iwmbtfw(8): Improve 7260 adaptors handling.

Tested. It works and is good to go. Intel 7260.
One nit: we have files from iwmbt-firmware located @ /usr/local/share/iwmbt-firmware/
and this present utility looks in /usr/share/firmware/intel.
Maybe we could make it look sequentially in one, then the other. ?

May 30 2021, 6:23 PM
pitwuu_gmail.com added a comment to D30543: iwmbtfw(8): Improve 7260 adaptors handling.
		/*
		 * Every command has its associated event: data must match
		 * what is recorded in the firmware file. Perform that check
		 * now.
		 *
		 * Some commands are mapped to more than one event sequence,
		 * in that case we can drop the non-patch commands, as we
		 * probably don't need them for operation of the card.
		 *
		 */
May 30 2021, 5:32 PM

May 25 2021

pitwuu_gmail.com added a comment to D30457: linuxulator: Some ptrace fixes...

Ah yes I forgot. There's a second point of failure in our current ptrace. Currently all signals emit an event for ptrace to consume, which is not the behaviour on Linux, where all signals emit a signal except SIGKILL which behaves normally.
From the man page:

May 25 2021, 5:42 PM
pitwuu_gmail.com requested review of D30457: linuxulator: Some ptrace fixes...
May 25 2021, 5:37 PM
pitwuu_gmail.com added a comment to D30378: linuxulator: Add filler for 'core' entry in linsysfs..

we have so many such unfinished things, like arm linuxulator, splice sys call....

Yes, about splice, I was thinking we could just use a regular copy and be done with it. It wouldn't be that hard to implement, I can possibly look at it.

some time ago I wrote splice emulation via dofileread/dofilewrite ) but I abandoned it because I think we need a native splice() and tee() implementation. feel free to as arch@ about it:)

May 25 2021, 5:02 PM · Linux Emulation, Core Team
pitwuu_gmail.com added a comment to D30378: linuxulator: Add filler for 'core' entry in linsysfs..

we have so many such unfinished things, like arm linuxulator, splice sys call....

Yes, about splice, I was thinking we could just use a regular copy and be done with it. It wouldn't be that hard to implement, I can possibly look at it.

some time ago I wrote splice emulation via dofileread/dofilewrite ) but I abandoned it because I think we need a native splice() and tee() implementation. feel free to as arch@ about it:)

The most pressing issue is the incomplete pthread support notably with FUTEX_LOCK_PI and FUTEX_UNLOCK_PI and friends.

https://wiki.freebsd.org/Linuxulator#Roadmap, pi is not the key, we have so many important holes

May 25 2021, 4:59 PM · Linux Emulation, Core Team
pitwuu_gmail.com added a comment to D30378: linuxulator: Add filler for 'core' entry in linsysfs..

Encountered in the crash handler of 'kodi'. Kodi still crashes, but at least the crash handler doesn't seem to crash anymore.

IMO this sort of thing is sufficient reason to have this linprocfs entry. What do you think about extending it slightly, at least translating FreeBSD's default %N.core to the Linux equivalent (%e.core I guess?)

we have so many such unfinished things, like arm linuxulator, splice sys call....

May 25 2021, 4:47 PM · Linux Emulation, Core Team
pitwuu_gmail.com added a comment to D30333: sound: add patch for Lenovo Legion 5 AMD..
lots of output
May 25 2021, 4:40 PM · Core Team
pitwuu_gmail.com added a comment to D30378: linuxulator: Add filler for 'core' entry in linsysfs..

Encountered in the crash handler of 'kodi'. Kodi still crashes, but at least the crash handler doesn't seem to crash anymore.

IMO this sort of thing is sufficient reason to have this linprocfs entry. What do you think about extending it slightly, at least translating FreeBSD's default %N.core to the Linux equivalent (%e.core I guess?)

May 25 2021, 4:35 PM · Linux Emulation, Core Team
pitwuu_gmail.com added a comment to D30378: linuxulator: Add filler for 'core' entry in linsysfs..

Is there a way to config git to do that by default? It's annoying to do every time.

I'm not sure, although I also suspect you don't want it when generating a patch for your own review, not for upload to Phabricator. There is a tool in the tree, tools/tools/git/git-arc, which can take care of submitting phab reviews for you.

May 25 2021, 4:23 PM · Linux Emulation, Core Team
pitwuu_gmail.com added a comment to D30378: linuxulator: Add filler for 'core' entry in linsysfs..

For future uploads please include full context by using e.g. git show -U99999 <hash> - see https://wiki.freebsd.org/Phabricator for details

May 25 2021, 4:13 PM · Linux Emulation, Core Team

May 23 2021

pitwuu_gmail.com added a comment to D30333: sound: add patch for Lenovo Legion 5 AMD..

Give us the output of 'pciconf -lv' please.

May 23 2021, 6:25 PM · Core Team

May 21 2021

pitwuu_gmail.com requested review of D30378: linuxulator: Add filler for 'core' entry in linsysfs..
May 21 2021, 12:01 PM · Linux Emulation, Core Team
pitwuu_gmail.com updated pitwuu_gmail.com.
May 21 2021, 11:50 AM

May 20 2021

pitwuu_gmail.com added a comment to D30333: sound: add patch for Lenovo Legion 5 AMD..

Please confirm Philippe Michaud-Boudreault <pitwuu@gmail.com> as the correct author info for Git.

May 20 2021, 9:36 AM · Core Team

May 18 2021

pitwuu_gmail.com requested review of D30333: sound: add patch for Lenovo Legion 5 AMD..
May 18 2021, 2:21 PM · Core Team
pitwuu_gmail.com requested review of D30332: linuxulator: Add FUTEX_REQUEUE for musl libc. .
May 18 2021, 2:15 PM · Linux Emulation