Page MenuHomeFreeBSD

linux: implement splice(2)
Needs ReviewPublic

Authored by trasz on Jun 1 2021, 3:32 PM.

Details

Reviewers
None
Group Reviewers
Linux Emulation

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 39642
Build 36531: arc lint + arc unit

Event Timeline

trasz requested review of this revision.Jun 1 2021, 3:32 PM

Cool. Thanks for working on it. Obviously this is an "emulation" way of implementing splice(2) and not the real thing, but I like this. Do you happen to know which software requires the splice(2) call for its correct operation?

Does this have test coverage via e.g. LTP?

Does this have test coverage via e.g. LTP?

yes, also linux source at tools/testing/selftests/splice

Does this have test coverage via e.g. LTP?

yes, also linux source at tools/testing/selftests/splice

It passes?

Does this have test coverage via e.g. LTP?

yes, also linux source at tools/testing/selftests/splice

It passes?

no, copy_file_range does not allow copying to/from pipes, only between vnode backed files

What error does kern_copy_file_range return if passed pipes

What error does kern_copy_file_range return if passed pipes

EINVAL, f_vnode == NULL check

(Tinderboxed.)

hmm, why? its unusable any way, at least one fd should be a pipe