User Details
- User Since
- Mar 22 2015, 5:29 PM (504 w, 3 d)
Feb 17 2020
Apr 7 2019
dbaio@ beat me to getting Azure CLI into ports :-)
Mar 31 2019
Mar 21 2019
Dec 14 2018
Dec 13 2018
Dec 12 2018
Dec 11 2018
Dec 10 2018
Nov 24 2018
Nov 22 2018
Nov 20 2018
Nov 11 2018
Nov 8 2018
Nov 2 2018
Oct 28 2018
Oct 24 2018
Oct 23 2018
Sep 24 2018
Sep 19 2018
This review is now too old, and way behind all the changes that happened to USES=python (especially the introduction of FLAVORS).
Sep 15 2018
Sep 12 2018
Sep 9 2018
Aug 29 2018
Aug 28 2018
Aug 22 2018
I think taking the simplest approach of slave ports for the libraries wine needs is the easiest. Are you thinking about any use case beyond wine?
Switch to using a slave port.
Aug 21 2018
Thank you all for the useful ideas. I think the first price approach is to create 'lib32-' companion packages for the 32-bit libraries we need. To this end I have created a patch that adds this functionality: https://reviews.freebsd.org/D16830. Luckily the approach is minimally invasive and often involves:
- Adding lib32 to USES
- Sometimes replacing uses of ${PREFIX}/lib} with ${LIBDIR}, however lib32 already handles CFLAGS, CPPFLAGS, and CONFIGURE_ARGS (this can be extended as needed)
- Sometimes adding USE_LDCONFIG=yes
Add missing Mk/Uses/lib32.mk file.
Aug 19 2018
Aug 18 2018
- Switch to using PyPI
- Remove the creation script
- Remove azure-cognitiveservices-vision-face (no PyPI package and not a dependency on any port)
- Manually change the version of azure-servicemanagement-legacy to align with PyPI
- Manually restore the "unordered" items in www/Makefile
Aug 17 2018
We have two failures and three skipped ports. The failures are do to unfetchable files from upstream. This does not affect lua, but of the dependents. I consider this a success and will commit this patch sometime during the day.
Aug 16 2018
Apologies, I've been sick. I've kicked of an exp-run: http://dbn.westeurope.cloudapp.azure.com/lua.html
Aug 10 2018
Add non-generated files
Aug 9 2018
Aug 7 2018
Jul 28 2018
FYI, commit messages require the full path to this review (your draft message [I assume] only includes the review number)
I cannot comment on the specifics of lua (i.e. do these changes work), I've never used lua and haven't tested it. However, I am happy with the above changes with the following comments:
- I assume the indentation is correct, despite it not rendering correctly in Chrome
- Please try to upstream all patches
I cannot comment on the specifics of lua (i.e. do these changes work), I've never used lua and haven't tested it. However, I am happy with the above changes with the following comments:
- I assume the indentation is correct, despite it not rendering correctly in Chrome
- Please try to upstream all patches (and well done on doing that for the previous version)
Jul 26 2018
The comments I mention are just suggestions. Happy for you to commit this patch without those changes.
Jul 13 2018
Jul 6 2018
Jul 3 2018
Jun 30 2018
All dependent reviews have been committed. We are now up-to-date with VS for Mac (give or take msbuild).
Committed in r473600