In D47562#1084777, @adrian wrote:

There's /gotta/ be a way to do this without having the channel code try get the USB pointer.

Lemme noodle on it, I think we should be able to move uc_delay_us into the rtwn softc, and make uc_write_delay a softc function? instead of how it's currently done?

Thu, Nov 14, 5:40 AM

cy added a comment to D47522: rtwn: change the USB TX transfers to only do one pending transfer per endpoint.

https://reviews.freebsd.org/D38854 and https://reviews.freebsd.org/D47562.

Thu, Nov 14, 2:46 AM · wireless

cy requested review of D47562: rtwn: Fix RTL8192EU cannot associate in STA mode.

Thu, Nov 14, 2:43 AM

cy added a comment to D47522: rtwn: change the USB TX transfers to only do one pending transfer per endpoint.

In D47522#1084687, @adrian wrote:

hm, looks like it may be a USB controller problem, hmph. Stay tuned.

Thu, Nov 14, 2:38 AM · wireless

Wed, Nov 13

cy committed R11:8b4200891506: security/sudo: Update to 1.9.16p1 (authored by cy).

security/sudo: Update to 1.9.16p1

Wed, Nov 13, 2:55 PM

cy committed R11:26f5b17f4283: security/sudo: Update to 1.9.16p1 (authored by cy).

security/sudo: Update to 1.9.16p1

Wed, Nov 13, 2:54 PM

Tue, Nov 12

cy committed rGfabc5e81bd04: ipfilter: Remove dead code from "Virtualize ipfilter" (authored by cy).

ipfilter: Remove dead code from "Virtualize ipfilter"

Tue, Nov 12, 10:01 PM

cy committed rG6e608d2990e9: ipfilter: ipfilter: Remove more dead code (authored by cy).

ipfilter: ipfilter: Remove more dead code

Tue, Nov 12, 10:01 PM

cy added a comment to D47530: ipfilter: Do not reinitialize lock in timer function.

In D47530#1084133, @jlduran wrote:

In D47530#1084128, @cy wrote:

This is the ticket. You will need to reapply the revert. Probably makes more sense to reapply while squashing this. I don't know if you need still mentor approval or if my approval is good enough.

Will do then. If you have other tests that you run, I would gladly try to add them to the suite (once I finish with other fixes), I feel ipfilter is "undertested", but I may be wrong.
I was explained that the approval of my mentor is an "administrative approval", and may not necessarily be a technical one, of course, having both is much more reassuring.

Thank you!

Tue, Nov 12, 8:55 PM

cy accepted D47530: ipfilter: Do not reinitialize lock in timer function.

This is the ticket. You will need to reapply the revert. Probably makes more sense to reapply while squashing this. I don't know if you need still mentor approval or if my approval is good enough.

Tue, Nov 12, 8:40 PM

cy committed rGfc32b5ddf3af: ipfilter: Remove dead code (authored by cy).

ipfilter: Remove dead code

Tue, Nov 12, 4:03 PM

cy requested review of D47527: ipfilter: Don't reinitialize lock in timer function.

Tue, Nov 12, 3:42 PM

cy committed rG9da30a23a5ec: ipfilter: Include the IP address in error message (authored by cy).

ipfilter: Include the IP address in error message

Tue, Nov 12, 3:29 AM

cy committed rG3a2cb65b6e6d: ipfilter: Support printing of IPv6 addresses in error message (authored by cy).

ipfilter: Support printing of IPv6 addresses in error message

Tue, Nov 12, 3:29 AM

cy committed rG858a7a27f5c8: ipfilter: Close a bracket in the poolnode error message (authored by cy).

ipfilter: Close a bracket in the poolnode error message

Tue, Nov 12, 3:28 AM

cy committed rG8aae4220d766: ipfilter: Print the hash name when adding a hashnode fails (authored by cy).

ipfilter: Print the hash name when adding a hashnode fails

Tue, Nov 12, 3:28 AM

cy committed rG42935716286e: ipfilter: Avoid overrunning the message buffer (authored by cy).

ipfilter: Avoid overrunning the message buffer

Tue, Nov 12, 3:28 AM

cy committed rG470c680cfbf5: ipfilter: Print the pool name when adding a poolnode fails (authored by cy).

ipfilter: Print the pool name when adding a poolnode fails

Tue, Nov 12, 3:28 AM

cy committed rGc607b3258f15: ntp: Switch to upstream man pages (authored by cy).

ntp: Switch to upstream man pages

Tue, Nov 12, 3:28 AM

cy closed D47319: ntp: Switch to upstream man pages.

Tue, Nov 12, 3:28 AM

Fri, Nov 8

cy accepted D47466: graphics/xpdf4: add Qt5/Qt6 flavors.

This looks better.

Fri, Nov 8, 6:08 PM

cy committed R11:bd6b7621c22c: sysutils/hammer2: Update to 1.2.6 (authored by cy).

sysutils/hammer2: Update to 1.2.6

Fri, Nov 8, 2:22 PM

Thu, Nov 7

cy committed R11:99d534c2df10: sysutils/am-utils: Fix amq -i timestamp segmentation violation (authored by cy).

sysutils/am-utils: Fix amq -i timestamp segmentation violation

Thu, Nov 7, 6:14 PM

cy committed R11:1a95684e28bf: sysutils/am-utils: Clean up MASTER_SITES (authored by cy).

sysutils/am-utils: Clean up MASTER_SITES

Thu, Nov 7, 6:14 PM

Mon, Nov 4

cy abandoned D47441: ipfilter: 128-bit radix support.

This needs more work.

Mon, Nov 4, 10:29 PM

cy added a comment to D47441: ipfilter: 128-bit radix support.

This has been sitting in my tree for 16 months. Probably time to get it into src/.

Mon, Nov 4, 9:22 PM

cy requested review of D47441: ipfilter: 128-bit radix support.

Mon, Nov 4, 9:20 PM

cy accepted D47436: ntpd: Fix crash when bringing up net interface fails.

Can you also submit a revision for the ntp port, please?

Mon, Nov 4, 6:27 PM

Fri, Nov 1

cy closed D47346: ipfilter: Set ipf -T optionlist at boot.

Fri, Nov 1, 6:09 PM

cy committed rG8d6feaaaa26f: ipfilter: Set ipf -T optionlist at boot (authored by cy).

ipfilter: Set ipf -T optionlist at boot

Fri, Nov 1, 6:09 PM

cy committed R11:590a6f3dd3c5: sysutils/lnav: Fix Makefile error (authored by cy).

sysutils/lnav: Fix Makefile error

Fri, Nov 1, 2:34 PM

cy added a comment to D47346: ipfilter: Set ipf -T optionlist at boot.

In D47346#1080517, @jlduran wrote:

Sorry, thinking more about it, this is essentially an rc patch.
The start action will always restart if there is an ipfilter_optionlist defined. Two questions:

Can ipfilter rely more on rc.subr?

Fri, Nov 1, 3:25 AM

Thu, Oct 31

cy updated the diff for D47346: ipfilter: Set ipf -T optionlist at boot.

This update makes the following changes:

Thu, Oct 31, 5:00 PM

cy added a comment to D47346: ipfilter: Set ipf -T optionlist at boot.

Fixed, plus another change.

Thu, Oct 31, 4:57 PM

cy accepted D47063: extend the use of the th_flags accessor function.

Builds now. Thanks.

Thu, Oct 31, 4:46 PM

cy accepted D47142: net/wifi-firmware-*kmod: update firmware for iwlwifi, rtw88, rtw89.

Thu, Oct 31, 4:55 AM

Wed, Oct 30

cy added a comment to D47345: net/ntp: add build_depends autogen.

Next time, can you please write what you'd like for a commit log entry. I'm not comfortable writing commit log entries for other people.

Wed, Oct 30, 8:05 PM

cy closed D47345: net/ntp: add build_depends autogen.

Wed, Oct 30, 7:56 PM

cy committed R11:fa93a47106ab: net/ntp: Fix build w/o autogen preinstalled (authored by concussious.bugzilla_runbox.com).

net/ntp: Fix build w/o autogen preinstalled

Wed, Oct 30, 7:56 PM

cy accepted D47345: net/ntp: add build_depends autogen.

LGTM

Wed, Oct 30, 7:50 PM

cy requested review of D47346: ipfilter: Set ipf -T optionlist at boot.

Wed, Oct 30, 7:36 PM

cy updated the diff for D47319: ntp: Switch to upstream man pages.

This update to the patch correctly replaces the upstream volume name with the correct man page volume number.

Wed, Oct 30, 5:50 PM

cy updated the diff for D47319: ntp: Switch to upstream man pages.

This is the way I should have built this from the start. Sadly I didn't put a . in front of SUFFIXES and that's why it didn't work.

Wed, Oct 30, 3:55 PM

cy updated the diff for D47319: ntp: Switch to upstream man pages.

Based on comments in this review there's some confusion because the independent privately maintained FreeBSD man pages remain. This latest upload removes those now.

Wed, Oct 30, 1:55 PM

cy added a comment to D47319: ntp: Switch to upstream man pages.

In D47319#1079497, @gperciva_tarsnap.com wrote:

Could you elaborate on why this patch doesn't modify usr.sbin/ntp/ ? Is it that since they're contributed files, they really belong in contrib/ anyway? (I have no objection if that's the motivation, but it would be nice to have that mentioned in the commit message.)

Wed, Oct 30, 1:53 PM