Good to go.

Can you also please submit a review for the port?

I sent (cc you) an email to Harlan Stenn, the primary developer at nwtime.org. (nwtime.org is replacing the ntp.org). Let's see what he says.

Why put the message here, now? It is not we (FreeBSD) who will deprecated it in a certain amount of time. It is nwtime.org that will. Should we not try to upstream this by submitting a patch to them first? Before we apply this patch here?

Update to the latest 15-STABLE is all that is needed.

I think this needs a little more investigation because k5-platform.h already includes autoconf.h. jrtc27@'s October patch should have been enough. I will rebuild again (cleanly).

In D55823#1277119, @emaste wrote:

I find it quite surprising that this would just be broken in the upstream build; is it possible this is an artifact of our bespoke build process? Presumably the Implement the POSIX strerror_r API in terms of the GNU strerror_r section has to be used on GNU systems?

In D55823#1277079, @michaelo wrote:

Is this something which should be upstream?

This patch only masks another problem. When this patch is applied, usr.bin/ldd32 fails on the same error. The symbols that are exported in lib/libc.so, are not exported in lib32/libc.so. The problem is elsewhere but not here.

My Heimdal builds also fail with the same error. Something has recently changed in the tree to cause these two unrelated Kerberosen to fail with the same libc objects not found.

In D55678#1274214, @emaste wrote:

krb5 build failures have been occurring for a while afaik, e.g. PR293258? 9cea0f0be79d should be a no-op since the now-removed (portions of) if conditions were always true .if ${${X_}LINKER_TYPE} != "bfd" || ${${X_}LINKER_VERSION} > 21750 and the part of .if ${${X_}LINKER_TYPE} == "bfd" && ${${X_}LINKER_VERSION} > 21750 after &&

LGTM

In D13356#1263806, @ziaee wrote:

I have a usb floppy disk. It attaches to the system as /dev/da0. I can test this this weekend.

In D13356#1263008, @bms wrote:

In D13356#1262904, @cy wrote:

Imported into my GIT repo. I will review the code and make any changes needed to get it working again.

OT: Hello Cy. Yes, I tried to send you a text message at the start of the year, but I think your cell number has changed since 2014. I want to make it out to BC again at some point this year as a friend from my high school days has had the operation to become Canadian, I believe.

Imported into my GIT repo. I will review the code and make any changes needed to get it working again.

In D13356#1262434, @imp wrote:

This hasn't landed. the feedback from way back wasn't addressed. We can restart. I see several things in this code just glancing at it that I didn't understand well enough to comment on years ago.