Page MenuHomeFreeBSD
Differential D42981

shells/44bsd-csh: remove sbrk use
Needs ReviewPublic
Actions

Authored by brooks on Dec 8 2023, 11:22 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 16, 8:28 AM
Unknown Object (File)
Sun, Apr 14, 11:23 PM
Unknown Object (File)
Jan 6 2024, 11:13 PM
Unknown Object (File)
Dec 30 2023, 11:14 AM
Subscribers
mjg

Details

Reviewers
cy
Summary

The allocator wrappers call sbrk(0) to track heap usage. With modern
malloc implementations this is of little value and sbrk is deprecated so
remove this functionality, but continue to provide a stub implemenation
of the alloc command.

Diff Detail

Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 54876
Build 51765: arc lint + arc unit

Event Timeline

brooks requested review of this revision.Dec 8 2023, 11:22 PM
brooks created this revision.
Harbormaster completed remote builds in B54876: Diff 131197.Dec 8 2023, 11:22 PM
brooks added a comment.Dec 8 2023, 11:23 PM

Compiled and minimally smoke tested on an amd64 world without sbrk support.

mjg added a subscriber: mjg.Dec 9 2023, 12:16 PM

why is this port still a thing

Revision Contents
Changeset List

PathSize
shells/
44bsd-csh/
5 lines
files/
48 lines

Diff 131197

View Options

shells/44bsd-csh/Makefile

Loading...
View Options

shells/44bsd-csh/files/patch-alloc.c

Loading...