Page MenuHomeFreeBSD
Feed Advanced Search

Jun 14 2022

damjan.jov_gmail.com added a comment to D34184: struct kinfo_file changes needed for lsof to work using only usermode APIs.
In D34184#804474, @kib wrote:

I still want the answer about use of the kernel addresses for kqueue/eventfd. Generally we try to not introduce new interfaces that directly expose KVA, whatever silly the idea of KASLR is.

Jun 14 2022, 12:36 AM · Contributor Reviews (base)

Apr 13 2022

damjan.jov_gmail.com added a comment to D34323: Add a kern.lockf sysctl to list the advisory byte-range locks on a specific vnode.

This is probably irrelevant now that D34756 added a more general way to retrieve advisory lock info.

Apr 13 2022, 5:32 PM · Contributor Reviews (base)
damjan.jov_gmail.com added a comment to D34184: struct kinfo_file changes needed for lsof to work using only usermode APIs.

Is this still relevant?
D34756 added a more general way to retrieve advisory lock info.

Apr 13 2022, 5:29 PM · Contributor Reviews (base)

Feb 22 2022

damjan.jov_gmail.com abandoned D34090: Kernel changes needed for lsof to work using only user mode APIs.

Thank you for your feedback. New versions of this patch are at:
https://reviews.freebsd.org/D34184
https://reviews.freebsd.org/D34323

Feb 22 2022, 7:05 PM · Contributor Reviews (base)

Feb 20 2022

damjan.jov_gmail.com updated the diff for D34184: struct kinfo_file changes needed for lsof to work using only usermode APIs.

Also:

  • Add a kf_eventfd_addr field to kf_eventfd and populate it.
Feb 20 2022, 12:58 PM · Contributor Reviews (base)
damjan.jov_gmail.com requested review of D34323: Add a kern.lockf sysctl to list the advisory byte-range locks on a specific vnode.
Feb 20 2022, 12:54 PM · Contributor Reviews (base)

Feb 6 2022

damjan.jov_gmail.com requested review of D34184: struct kinfo_file changes needed for lsof to work using only usermode APIs.
Feb 6 2022, 12:03 PM · Contributor Reviews (base)

Feb 2 2022

damjan.jov_gmail.com added a comment to D34090: Kernel changes needed for lsof to work using only user mode APIs.

Kernel changes needed for lsof to work using only user mode APIs,

Can you confirm that with the set of changes here and without use of kvm, lsof's full functionality is available?

Feb 2 2022, 3:50 AM · Contributor Reviews (base)

Jan 29 2022

damjan.jov_gmail.com updated the diff for D34090: Kernel changes needed for lsof to work using only user mode APIs.

Added kf_pipe_buffer_[in/out/size] fields to kf_pipe.

Jan 29 2022, 12:16 PM · Contributor Reviews (base)
damjan.jov_gmail.com requested review of D34090: Kernel changes needed for lsof to work using only user mode APIs.
Jan 29 2022, 10:30 AM · Contributor Reviews (base)

Dec 6 2021

damjan.jov_gmail.com added a comment to D33277: fcntl(2): add F_KINFO operation.
In D33277#752192, @kib wrote:

Why not a sysctl-based interface, where the fd is a component of the MIB? Then info for a specific fd can be grabbed from a different process.

There is already kern.proc.filedesc, and I highly doubt that somebody needs a path for individual fd of remote process.

Dec 6 2021, 1:36 AM

Sep 19 2021

damjan.jov_gmail.com requested review of D32018: devel/gvfs should depend on sysutils/lsof.
Sep 19 2021, 3:27 AM · Contributor Reviewers (ports)

May 4 2018

damjan.jov_gmail.com created D15297: msdosfs: use vfs_timestamp() to generate timestamps instead of getnanotime().
May 4 2018, 5:53 PM · Src Committers