Good catch, thanks!

Thank you!

Looks good, thanks! However, we should add the same control for the DEV_TAP at line 1860.

Thanks, but the commit looks a bit strange: we are treating the pdev as a bus_dma_tag_t when it's really a pointer to a netmap adapter. It is not used at all on FreeBSD so it doesn't really matter, but maybe I'm missing something.

Usage of "struct device *" was just wrong. Thanks spotting the issue.
Commit 70275a6735df8a514f48be77418491f2f8dba817 should have the same effect.

Now that libnetmap has been merged and valectl updated, we can apply part of this change (documentation, usage, error checking).

Not relevant anymore.

Forgot to link the commit to this review.

Il giorno ven 19 mar 2021 alle ore 18:24 markj (Mark Johnston) <
phabric-noreply@freebsd.org> ha scritto:

Addressed reviewer comments

It may also help to use these commands (available on freefall) to look for style issues

Looks ok, thanks.

It can be merged there (MFC'd) as well, after a period of a minimum of 3 days. There is no need to submit a separate patch.

Will the fix be provided as a firmware upgrade or how?
I could commit this change if you don't have someone else around that can do that for you.

Wouldn't it be easier to always perform the complete phy reset if this is a known hardware issue? Or maye perform it automatically after a normal reset does not work?
I'm afraid that adding an obscure sysctl (obscure for anyone except for the axgbe developers) would be of little use. Unaware users wouldn't have a clue about what to do...
just my 2 cents

Shall I commit this change?

Looks good to me.

I added some comments, mostly about readability.
If you tested all the valid combinations of sph_enable and netmap/non-netmap I don't have any objection in this being merged.

Il giorno dom 10 gen 2021 alle ore 13:20 rajesh1.kumar_amd.com (Rajesh
Kumar) <phabric-noreply@freebsd.org> ha scritto:

Thanks to both for the clarification.