I've provided an actual diff revision URL and removed [PATCH] prefix from the commit message.

I've just got a kernel panic at the same place with IOMMU enabled and DPAA2 driver WIP on Honeycomb board.

outid will be written in case of a non-null output node found only. This is how iort_pci_rc_map() used to work and I don't want my patch to change this behavior.

Shared parts of the iort_pci_rc_map() and iort_named_comp_map() were extracted into a separate iort_smmu_trymap() function.

@andrew It definitely won't be, but I wanted to have a separate function for named components from IORT table similar to one for PCI RC nodes. I'll probably extract the same parts of the both functions into a separate one.

You won't see "MSI allocated" in dmesg if you clone the repository or pull the latest changes now. Please, ping me and I'll explain how to test this patch.

@mhorne, @andrew, thanks for help here :)

@mhorne Should I update a patch attached to the PR also: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251053 ?

Unnecessary tests of the devtype argument have been removed from uart_cpu_getdev() in sys/dev/uart/uart_cpu_arm64.c and sys/dev/uart/uart_cpu_fdt.c. uart_cpu_fdt_probe() checks for console types it supports.

Please, take a look at the updated patch.

I've tried to follow all of the comments during the review.

There's some information here if you haven't found it already: https://wiki.freebsd.org/Phabricator

No, I haven't seen it yet - thanks for sharing! What's a preferred way to create a revision: via command line or web interface?

Would you be willing to create a new phabricator review for the change?

I've re-worked this patch and opened a PR at https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=251053.